Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pnpm 9, update pnpm setup action version #960

Merged
merged 5 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fetch-depth: 0
token: ${{ secrets.SEEK_OSS_CI_GITHUB_TOKEN }}

- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v3

- name: Set up Node.js
uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
with:
fetch-depth: 0

- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v3

- name: Set up Node.js
uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: actions/checkout@v4

- id: pnpm-setup
uses: pnpm/action-setup@v2
uses: pnpm/action-setup@v3

- name: Set up Node.js
uses: actions/setup-node@v3
Expand Down
4 changes: 0 additions & 4 deletions .npmrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,3 @@ public-hoist-pattern[]="*prettier*"
# This bypasses the .pnpm folder that resolveModules looks for
# See https://github.com/seek-oss/sku/blob/275752bd3066e52885d461ef5bcd953aaac3bfff/config/webpack/resolveModules.js
public-hoist-pattern[]="@babel/*"

# `docsify-cli` depends on `docsify` which depends on `opencollective-postinstall` and calls it during `postinstall`.
# For some reason, this call fails on CI, so we need to hoist it.
public-hoist-pattern[]="opencollective-postinstall"
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@
},
"volta": {
"node": "18.16.0",
"pnpm": "8.15.7"
"pnpm": "9.1.0"
},
"packageManager": "pnpm@8.15.7",
"packageManager": "pnpm@9.1.0",
"skuSkipPostInstall": true,
"skuSkipConfigure": true,
"skuSkipValidatePeerDeps": true
Expand Down