Flatten skuba bundle #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: f746389 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note that this doesn't actually implement the migration path from seek-module-toolkit; that's tracked in #13. |
72636c
added a commit
that referenced
this pull request
Jun 6, 2020
This builds on the proposal in #11 with a separate command for migration from `smt build`.
12 tasks
12 tasks
72636c
added a commit
that referenced
this pull request
Jun 6, 2020
This builds on the proposal in #11 with a separate command for migration from `smt build`.
72636c
added a commit
that referenced
this pull request
Jun 6, 2020
This builds on the proposal in #11 with a separate command for migration from `smt build`.
A prominent pain point I've observed working with seek-module-toolkit is that it compiles to nested directories like `/lib/commonjs`. This means that the depth of the compiled file differs from the source file under `/src`, which can make bundling and referencing of non-JS assets more of a hassle than it should be. I propose that we instead compile to `/lib-commonjs`, and document this as a potential breaking change when migrating from seek-module-toolkit. skuba itself moves to this model as a guinea pig. I've taken this opportunity to revise the ignore files to account for proposed directories like `/lib-commonjs`.
tobyhei
approved these changes
Jun 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prominent pain point I've observed working with seek-module-toolkit is that it compiles to nested directories like
/lib/commonjs. This means that the depth of the compiled file differs from the source file under/src, which can make bundling and referencing of non-JS assets more of a hassle than it should be.I propose that we instead compile to
/lib-commonjs, and document this as a potential breaking change when migrating from seek-module-toolkit. skuba itself moves to this model as a guinea pig.I've taken this opportunity to revise the ignore files to account for proposed directories like
/lib-commonjs.