Store project type to tailor configuration #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new `package.json#/skuba/type` field that is used by `skuba configure` to tailor logic based on whether we're dealing with an application or package. This could be extended in future to somehow enable a monorepo type, but it's probably too early to say.
🦋 Changeset is good to goLatest commit: bd2d33d We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Jun 18, 2020
| @@ -79,11 +134,79 @@ describe('packageModule', () => { | |||
| const outputData = parsePackage(outputFiles['package.json']); | |||
|
|
|||
| assertDefined(outputData); | |||
| expect(outputData.license).toBe('UNLICENSED'); | |||
| expect(outputData.license).toBe('MIT'); | |||
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
package.json#/skuba/typefield that is used byskuba configureto tailor logic based on whether we're dealing with an application or package. This could be extended in future to somehow enable a monorepo type, but it's probably too early to say.