Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register tsconfig-paths for development #678

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

72636c
Copy link
Member

@72636c 72636c commented Nov 17, 2021

Note that this does not modify our typical skuba-dive/register runtime hook. The drift between the two may be a bit puzzling in the time being, but it's somewhat rare for production applications to include tsconfig.json in their final bundle or container. Alignment should eventually come as we investigate shifting over to esbuild, which supports compile-time tsconfig-paths resolution.

Note that this does not modify our typical `skuba-dive/register` runtime
hook. The drift between the two may be a bit puzzling in the time being,
but it's somewhat rare for production applications to include
`tsconfig.json` in their final bundle or container. Alignment should
eventually come as we investigate shifting over to `esbuild`, which
supports compile-time `tsconfig-paths` resolution.
@72636c 72636c requested a review from a team as a code owner November 17, 2021 00:42
@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

🦋 Changeset detected

Latest commit: 451decc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@72636c 72636c merged commit c09c831 into master Nov 17, 2021
@72636c 72636c deleted the tsconfig-paths-dev branch November 17, 2021 01:13
@github-actions github-actions bot mentioned this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants