Add OpenTelemetry support for Koa template #706

runk · 2021-11-30T07:18:44Z

This brings https://opentelemetry.io/ support, which can be enabled via gantry config (deploys another sidecar that collects the data). According to @bernos it's here to stay and should no longer be considered an experimental feature. Yet has to be widely announced.

All traces can be viewed in "Technology Platforms" DD org.

This PR is a first step - one template only - koa app.

changeset-bot · 2021-11-30T07:18:46Z

🦋 Changeset detected

Latest commit: 0126a2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
skuba	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

runk · 2021-11-30T07:21:30Z

template/koa-rest-api/src/tracing.ts

+  return sdk.start();
+};
+
+const log = (level: string, msg: string, extra = {}) => {


I'm hesitant to bring in the standard logger as it might bring more dependencies before the internals are instrumented. This lib really meant to be self-contained.

Thoughts?

runk · 2021-11-30T07:22:07Z

template/koa-rest-api/src/listen.ts

@@ -1,5 +1,3 @@
-import './register';


It's loaded in app.ts

I think this is here to make it obvious (to humans but also to e.g. linters) that the import has side effects and must go first. It's easy to shoot yourself in the foot by importing something else before ./app, which is part of the reason why I'd like to get rid of this hook soon™️.

template/koa-rest-api/gantry.apply.yml

samchungy · 2021-11-30T12:14:16Z

template/koa-rest-api/package.json

    "@seek/logger": "^5.0.1",
-    "skuba-dive": "^1.2.0",
+    "aws-sdk": "^2.1039.0",


question: do you need to declare this as a dep?

I think it's up for discussion. It's needed for aws-sdk instrumentation, which I guess is highly desirable for anyone at seek. Perhaps some don't use aws-sdk but I bet it's the minority.

I think when I flipped through the GitHub page it said you could use aws-sdk V3 as well?

Actually, otel won't work with aws-sdk < V3. At least it wasn't in early testing. This was because in V2 of the aws SDK, request signing was happening before otel header propagation. This meant that all instrumented requests to AWS services via the AWS SDK would fail on account of invalid signatures. This wasn't an issue in V3

@bernos re aws-sdk v2 - I can confirm instrumentation works for it with current otel libraries.

Would it be better to just leave it out and let consumers byo sdk?

It depends on your definition of "better", as always :). Do we want to bring in aws-sdk instrumentation for consumers out of the box?

Looking at this trace - I see clear advantages of knowing what the HTTP POST actually was about, which in the case with aws-sdk instrumentation is very illustrative. With minimal built-in http instrumentation it'll be just another opaque HTTP request.

The problem is https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-aws-sdk needs aws-sdk (or rather its types)

template/koa-rest-api/package.json

etaoins · 2021-11-30T21:44:52Z

Has this been running in production yet? Any early performance insights versus no instrumentation or Datadog APM?

runk · 2021-11-30T22:29:15Z

Has this been running in production yet? Any early performance insights versus no instrumentation or Datadog APM?

Otel is in production for about ~20 services today, however only some have code instrumentation enabled. Most of those 20 services have the flag set in gantry which enables tracing in auth-sidecar only. I can see there are only 4 services that have code instrumentation enabled across a couple of teams. There're some heavy-loaded systems like the API router that is instrumented though. Also it comes down that what we want to instrument, e.g. both aws-sdk and node's http or only one one of those.

Re DD APM - I think it'd be a similar performance hit as with automatic instrumentation as all outgoing requests (and other i/o commands) are wrapped.

Stats for one of the services:

(red line is when it went live)

Number of tasks didn't go up so CPU avg is somewhat reliable representation of possible performance hit.

I'll try to get similar insights for another service that's hit a bit harder.

runk · 2021-11-30T23:02:59Z

Okay, there're two discreet parts - app code instrumentation (controlled via tracing.ts) and auth sidecar instrumentation (controlled via gantry config). The previous chart was for the case when we already had Otel enabled in gantry (think auth sidecar) and just added code instrumentation in the app itself. No visible performance hit could be seen.

However, when enabled in gantry AND app, there's about 2-3ms latency increase. I'm inclined to believe it's mainly attributed to sidecar instrumentation.

etaoins · 2021-11-30T23:07:31Z

Is that expected @bernos? I don't recall that showing up on indie-graphql-server. Seems like a large regression for a feature teams might not end up using.

etaoins

Talking with @runk offline, there's potentially a large performance regression for some workloads (33%-50%). I'm happy to include this as a default off to allow teams to opt-in to tracing if they find it useful. This is similar to what we do with Datadog APM.

runk · 2021-12-01T01:04:03Z

Changed to be opt-in.

I think as an alternative (a middle ground?) we can to have the tracing on in auth sidecar by default, but keep app instrumentation off by default. I think this way possible performance hit as you experienced with DD APM will be an unlikely scenario.

runk · 2021-12-01T01:09:23Z

The graph shows the service in three modes:

Bare app (before 9:15)
Sidecar + App instrumentation (9:15-10:38)
Sidecar instrumentation only (10:38 onwards)

While latency increase is a single digit, it could mean a ~30% increase for a fast-responding app. Assuming if the app is doing a lot of network calls and all be instrumented (e.g. Experience APIs/Graphql servers), the more serious performance hit of app instrumentation should be expected. I do not see time spent for sidecar instrumentation to differ depending on nature of the app itself.

bernos · 2021-12-01T01:23:56Z

template/koa-rest-api/package.json

    "@seek/logger": "^5.0.1",
-    "skuba-dive": "^1.2.0",
+    "aws-sdk": "^2.1039.0",


Actually, otel won't work with aws-sdk < V3. At least it wasn't in early testing. This was because in V2 of the aws SDK, request signing was happening before otel header propagation. This meant that all instrumented requests to AWS services via the AWS SDK would fail on account of invalid signatures. This wasn't an issue in V3

bernos · 2021-12-01T01:31:36Z

template/koa-rest-api/src/tracing.ts

+import { B3InjectEncoding, B3Propagator } from '@opentelemetry/propagator-b3';
+import { NodeSDK } from '@opentelemetry/sdk-node';
+
+const main = async () => {


Does async code loaded via --require behave any differently to async code called from the entry point? ie. is there a race here between instrumentation being initialised and the first requests being handed by the service?

Good point. I think it's definitely a possibility that promises aren't fulfilled before the app loads. Today there's no way to pause for async execution in the bootstrap file supplied via --require x.js.

Really depends on what happens inside of the sdk.start fn: https://www.npmjs.com/package/@opentelemetry/sdk-node. Looking in code it only really returns a pending promise when we want auto resource detection which is off: https://github.com/seek-oss/skuba/pull/706/files#diff-4836bf38ef9493029c23deb46fdf06733bbc8b8cec520b9f538ea1a68cebf8eaR33

I'm going to remove async from the main fn to keep it simple. However it's only hiding the possible problem with pending promise from sdk.start()

bernos · 2021-12-01T01:36:27Z

This is great, happy to roll it out, but please don't default any open telemetry options to enabled by default just yet. The cost implications of mass adoption are still not well understood, and we'd like to avoid any shock there. There are contingencies and compensations that we can make in the event that costs exceed the forecast, but we need a bit more control over the rate of adoption in order to have time to adapt if needs be. Also, I mentioned an incompatibility with aws-sdk < v3 that may have been addressed in newer releases of v2, but there should probably be a warning on the tin.

runk · 2021-12-03T02:47:50Z

@samchungy @etaoins do you want to check it one more time before I merge? The notable change is the addition of process exit handling: https://github.com/seek-oss/skuba/pull/706/files#diff-4836bf38ef9493029c23deb46fdf06733bbc8b8cec520b9f538ea1a68cebf8eaR46

samchungy · 2021-12-03T02:49:14Z

@samchungy @etaoins do you want to check it one more time before I merge? The notable change is the addition of process exit handling: https://github.com/seek-oss/skuba/pull/706/files#diff-4836bf38ef9493029c23deb46fdf06733bbc8b8cec520b9f538ea1a68cebf8eaR46

@72636c your review probably holds the most weight here 😆

72636c · 2021-12-13T06:08:14Z

template/koa-rest-api/src/listen.ts

@@ -1,5 +1,3 @@
-import './register';


I think this is here to make it obvious (to humans but also to e.g. linters) that the import has side effects and must go first. It's easy to shoot yourself in the foot by importing something else before ./app, which is part of the reason why I'd like to get rid of this hook soon™️.

72636c · 2021-12-13T06:11:36Z

template/koa-rest-api/package.json

+    "@opentelemetry/exporter-collector-grpc": "^0.25.0",
+    "@opentelemetry/instrumentation-aws-sdk": "^0.1.0",
+    "@opentelemetry/instrumentation-http": "^0.26.0",
+    "@opentelemetry/sdk-node": "^0.26.0",


Do we need to be concerned about these v0s? Does OpenTelemetry promise some degree of stability?

template/koa-rest-api/Dockerfile

.changeset/brown-bananas-repair.md

template/koa-rest-api/src/tracing.ts

template/koa-rest-api/gantry.apply.yml

template/koa-rest-api/src/tracing.ts

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

72636c · 2021-12-16T00:48:24Z

template/koa-rest-api/src/tracing.ts

+import { B3InjectEncoding, B3Propagator } from '@opentelemetry/propagator-b3';
+import { NodeSDK } from '@opentelemetry/sdk-node';
+
+const app = 'opentelemetry';


For posterity, I was wondering where this app log field convention was from and it looks like our sidecar follows suit.

Old mate ca-go-library 🙈

seek-auth-sidecar was originally ca-auth-sidecar and used the default logger from ca-go-library. The newer name convention comes from Pino/Bunyan.

runk requested a review from a team as a code owner November 30, 2021 07:18

runk force-pushed the add-otel-support branch from 730954c to 735fb53 Compare November 30, 2021 07:19

runk commented Nov 30, 2021

View reviewed changes

samchungy reviewed Nov 30, 2021

View reviewed changes

template/koa-rest-api/package.json Outdated Show resolved Hide resolved

etaoins approved these changes Dec 1, 2021

View reviewed changes

bernos reviewed Dec 1, 2021

View reviewed changes

runk force-pushed the add-otel-support branch from 623e27e to 32d09a8 Compare December 1, 2021 03:58

Add opentelemetry support for koa-app template

dd47b67

runk force-pushed the add-otel-support branch from 8f6bf48 to dd47b67 Compare December 1, 2021 23:03

Merge branch 'master' into add-otel-support

2716946

72636c reviewed Dec 13, 2021

View reviewed changes

runk and others added 7 commits December 16, 2021 10:39

Update template/koa-rest-api/src/tracing.ts

1c059db

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

Update template/koa-rest-api/gantry.apply.yml

64cfafb

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

Update template/koa-rest-api/src/tracing.ts

75fd423

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

Update template/koa-rest-api/src/tracing.ts

6235f7b

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

Update template/koa-rest-api/Dockerfile

ee929da

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

Update .changeset/brown-bananas-repair.md

d242dd3

Co-authored-by: Ryan Ling <ryan@outlook.com.au>

Tweak log copy

1d9e3af

72636c approved these changes Dec 16, 2021

View reviewed changes

Merge branch 'master' into add-otel-support

0126a2a

72636c changed the title ~~Add opentelemetry support for koa-app template~~ Add OpenTelemetry support for Koa template Dec 28, 2021

72636c merged commit baae6b3 into master Dec 28, 2021

72636c deleted the add-otel-support branch December 28, 2021 22:46

github-actions bot mentioned this pull request Dec 28, 2021

Version Packages #669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OpenTelemetry support for Koa template #706

Add OpenTelemetry support for Koa template #706

runk commented Nov 30, 2021 •

edited

Loading

changeset-bot bot commented Nov 30, 2021 •

edited

Loading

runk Nov 30, 2021 •

edited

Loading

runk Nov 30, 2021

72636c Dec 13, 2021

samchungy Nov 30, 2021

runk Nov 30, 2021

samchungy Nov 30, 2021

bernos Dec 1, 2021

runk Dec 1, 2021

samchungy Dec 1, 2021

runk Dec 1, 2021 •

edited

Loading

etaoins commented Nov 30, 2021

runk commented Nov 30, 2021 •

edited

Loading

runk commented Nov 30, 2021

etaoins commented Nov 30, 2021

etaoins left a comment

runk commented Dec 1, 2021

runk commented Dec 1, 2021 •

edited

Loading

bernos Dec 1, 2021

bernos Dec 1, 2021

runk Dec 1, 2021 •

edited

Loading

bernos commented Dec 1, 2021

runk commented Dec 3, 2021

samchungy commented Dec 3, 2021

72636c Dec 13, 2021

72636c Dec 13, 2021

72636c Dec 16, 2021

etaoins Dec 16, 2021

Add OpenTelemetry support for Koa template #706

Add OpenTelemetry support for Koa template #706

Conversation

runk commented Nov 30, 2021 • edited Loading

changeset-bot bot commented Nov 30, 2021 • edited Loading

🦋 Changeset detected

runk Nov 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

runk Dec 1, 2021 • edited Loading

Choose a reason for hiding this comment

etaoins commented Nov 30, 2021

runk commented Nov 30, 2021 • edited Loading

runk commented Nov 30, 2021

etaoins commented Nov 30, 2021

etaoins left a comment

Choose a reason for hiding this comment

runk commented Dec 1, 2021

runk commented Dec 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

runk Dec 1, 2021 • edited Loading

Choose a reason for hiding this comment

bernos commented Dec 1, 2021

runk commented Dec 3, 2021

samchungy commented Dec 3, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

runk commented Nov 30, 2021 •

edited

Loading

changeset-bot bot commented Nov 30, 2021 •

edited

Loading

runk Nov 30, 2021 •

edited

Loading

runk Dec 1, 2021 •

edited

Loading

runk commented Nov 30, 2021 •

edited

Loading

runk commented Dec 1, 2021 •

edited

Loading

runk Dec 1, 2021 •

edited

Loading