Use eslint-config-skuba
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 69424b4 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
commented
Jun 19, 2020
Comment on lines
-55
to
-56
| "eslint-plugin-jest": "^23.13.2", | ||
| "eslint-plugin-tsdoc": "^0.2.5", |
There was a problem hiding this comment.
In particular, ESLint's docs seem to indicate that it shouldn't be possible to transitively bundle plugins 😕: https://eslint.org/docs/developer-guide/shareable-configs#publishing-a-shareable-config
tobyhei
approved these changes
Jun 19, 2020
| "eslint-config-seek": "^7.0.1", | ||
| "eslint-plugin-jest": "^23.13.2", | ||
| "eslint-plugin-tsdoc": "^0.2.5", | ||
| "eslint-config-skuba": "1.0.0", |
There was a problem hiding this comment.
Comment on lines
-55
to
-56
| "eslint-plugin-jest": "^23.13.2", | ||
| "eslint-plugin-tsdoc": "^0.2.5", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is suspiciously easy; I may cut a beta release to verify it's actually working as intended.