Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export = recommendation #90

Merged
merged 6 commits into from
Oct 12, 2020
Merged

Remove export = recommendation #90

merged 6 commits into from
Oct 12, 2020

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jun 21, 2020

This is a weird TypeScript special and isn't supported by Babel.

This is a weird TypeScript special and isn't supported by Babel.
@72636c 72636c requested a review from a team as a code owner June 21, 2020 11:54
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2020

🦋 Changeset detected

Latest commit: 380b813

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c changed the title Remove export = recommendation from README Remove export = recommendation Jun 21, 2020
@72636c 72636c marked this pull request as draft June 21, 2020 12:20
Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying

@72636c
Copy link
Member Author

72636c commented Jun 21, 2020

I'm going to leave this in draft; I think the better outcome would be to get koa-cluster to support named exports

We've dropped clustering as a default now

@72636c 72636c marked this pull request as ready for review October 12, 2020 23:31
@72636c 72636c requested review from a team and etaoins October 12, 2020 23:31
@72636c 72636c merged commit ea1de97 into master Oct 12, 2020
@72636c 72636c deleted the less-export-equals branch October 12, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants