Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registered sample drop-down not work properly in dynamic table #1894

Closed
kdp-cloud opened this issue May 23, 2024 · 0 comments · Fixed by #1897
Closed

Registered sample drop-down not work properly in dynamic table #1894

kdp-cloud opened this issue May 23, 2024 · 0 comments · Fixed by #1897
Assignees
@kdp-cloud
Labels
bug
Projects
SEEK 1.15.x
Milestone
1.15.1

Comments

@kdp-cloud
Copy link
Collaborator

When an ISA JSON compliant sample type has a registered sample attribute, a simple dropdown is added to the dynamic table:
image

There are two problems:

  1. If the attribute is not mandatory, users cannot remove it
  2. It is not possible to edit this attribute

Possible solutions:

  1. Make it a select 2 element => Prefered
  2. Convert it to text like it is the case with controlled vocabularies
@kdp-cloud kdp-cloud added the bug label May 23, 2024
@kdp-cloud kdp-cloud added this to the 1.15.1 milestone May 23, 2024
@kdp-cloud kdp-cloud added this to To do in SEEK 1.15.x via automation May 23, 2024
@kdp-cloud kdp-cloud self-assigned this May 23, 2024
@kdp-cloud kdp-cloud mentioned this issue May 24, 2024
Merged
@kdp-cloud kdp-cloud linked a pull request May 24, 2024 that will close this issue
Fix registered sample attribute #1897
Merged
SEEK 1.15.x automation moved this from To do to Done May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdp-cloud kdp-cloud

Labels
bug
Projects
DataHub
Status: Merged
SEEK 1.15.x
Done
Milestone
1.15.1
Development

Successfully merging a pull request may close this issue.

Fix registered sample attribute ELIXIR-Belgium/seek
1 participant
@kdp-cloud