Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update code to reflect 1.3 #29

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Fix: update code to reflect 1.3 #29

merged 6 commits into from
Mar 8, 2024

Conversation

tmullanix
Copy link
Collaborator

The code was out of date with the 1.3.0 zipfile. See #27

@tmullanix tmullanix requested a review from m-mead February 4, 2024 21:14
@@ -0,0 +1,260 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is out of the scope of this pull request, but I think it makes sense to consolidate the changes in this file into examples/seekcamera-opencv.py. The recording changes are helpful and don't overload the purpose of this file in my opinion.

Copy link
Collaborator

@m-mead m-mead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. I left two small comments but am approving this either way.

Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
@tmullanix tmullanix merged commit 3b056f9 into main Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants