-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update code to reflect 1.3 #29
Conversation
@@ -0,0 +1,260 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is out of the scope of this pull request, but I think it makes sense to consolidate the changes in this file into examples/seekcamera-opencv.py
. The recording changes are helpful and don't overload the purpose of this file in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. I left two small comments but am approving this either way.
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
The code was out of date with the 1.3.0 zipfile. See #27