Fix return value of poll_host_device #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving frames and no further frames are available, read() returns EAGAIN. In the previous implementation, frames would not be processed until the circular multicast buffer is full, resulting in a periodic burst of packets. In general, a receive failure should not affect processing of packets that were already successfully received. Tested on: - TP-Link Archer T1U V1.0 (mt76) - Alfa AWUS036NHA (ath9k_htc)
|
Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving frames and no further frames are available,
read()returnsEAGAIN. In the previous implementation, frames would not be processed until the circular multicast buffer is full, resulting in a periodic burst of packets. In general, a receive failure should not affect processing of packets that were already successfully received.I observed this behavior in #38 (comment) where I ping the broadcast address from the machine running owl.
Tested on: