Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.6 Deployment - Speed up Vector3Array validation #270

Merged
merged 5 commits into from
Mar 1, 2019
Merged

v0.5.6 Deployment - Speed up Vector3Array validation #270

merged 5 commits into from
Mar 1, 2019

Conversation

fwkoch
Copy link
Contributor

@fwkoch fwkoch commented Mar 1, 2019

Vector3Array validation is simplified to not include the check for string representations (e.g. 'up', 'east') if using a numpy array. This vastly speeds up validation for large arrays since we no longer must iterate through every value.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #270 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   96.36%   96.36%   +<.01%     
==========================================
  Files          17       17              
  Lines        2366     2367       +1     
==========================================
+ Hits         2280     2281       +1     
  Misses         86       86
Impacted Files Coverage Δ
properties/math.py 98.56% <100%> (ø) ⬆️
properties/utils.py 96.55% <100%> (ø) ⬆️
properties/base/base.py 99.09% <100%> (ø) ⬆️
properties/__init__.py 76% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2014e3...da2a0f0. Read the comment docs.

@fwkoch fwkoch merged commit 9fd6fb0 into master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant