-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow testing q3c without having PostgreSQL headers installed #28
Allow testing q3c without having PostgreSQL headers installed #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me and passes all the CI tests. The only concern is the
typedef long long int64
I am reluctant to have that as that may not be correct on all platforms, and may result
in incorrect code.
It's probably better to use a proper C type, yes. For the Debian patch I wanted to keep the diff short. (It does pass the tests on 20 architectures here.) Will update the PR. |
Debian tries to run the testsuite on the installed packages with as few extra dependencies as possible. This change allows compiling gen_data and invoking "make test" without having postgresql-server-dev-* installed.
e51b8d5
to
ed02145
Compare
Fwiw I'm getting a regression diff on master which I think isn't my fault:
|
I've committed your PR, thanks. |
Thanks for merging. I'm seeing in on Debian bullseye (unstable should be the same) amd64 with PG13:
|
Thanks, do you think you could run this query for me
to understand what's going on. I don't see anything on travis, so that's the only thing that can help. |
Debian tries to run the testsuite on the installed packages with as few
extra dependencies as possible. This change allows compiling gen_data
and invoking "make test" without having postgresql-server-dev-*
installed.