Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vorbis class doesn't properly return sample buffer fill #2

Closed
segin opened this issue Mar 27, 2024 · 0 comments
Closed

Vorbis class doesn't properly return sample buffer fill #2

segin opened this issue Mar 27, 2024 · 0 comments

Comments

@segin
Copy link
Owner

segin commented Mar 27, 2024

Vorbis::getData() doesn't return how much of the buffer was actually filled with data; brief bursts of unexpected noise can be played at the very end of some Vorbis tracks.

Plus GCC chastises about it:

vorbis.cpp: In member function ‘virtual size_t Vorbis::getData(size_t, void*)’:
vorbis.cpp:86:1: warning: no return statement in function returning non-void [-Wreturn-type]                                                                                                                                                 
   86 | }                                                                                                                                                                                                                                       
      | ^
@segin segin closed this as completed in 7f1718a Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant