NSAssert: Key url is a NSURL and can't be serialized for delivery

[krin-san]

Segment cannot handle app start options dictionary on iOS 14 when it contains deeplink url (when application was started to handle that deep link).

Related to #937 and #936
Affected version: v4.0.5 and 7a8387b (latest master at the moment of testing).
iOS version: 14.0.1
IDE: Xcode 12.0.1

Issues:

• Assertion in -[NSDictionary(SerializableDeepCopy) serializableDeepCopy:] on DEBUG builds
• Missing tracking data (deep link) on other builds

Reasons:

• NSURL is not mentioned in

  analytics-ios/Segment/Internal/SEGUtils.m

  Line 507 in 7a8387b

  + (BOOL)isOfSerializableType:(id)obj

• NSURL don't conform to SEGSerializable

LLDB log at selected stack trace point:

po note.userInfo
{
    UIApplicationLaunchOptionsURLKey = "my_app://deeplink";
}

po [note.userInfo[@"UIApplicationLaunchOptionsURLKey"] class]
NSURL

[krin-san]

Adding [obj isKindOfClass:[NSURL class]] || to the list of serializable classes seem to fix this issue.

[dannyhertz]

Im running into this issue as well. Were you able to patch it locally @krin-san or did you have to fork the library and fix it yourself?

[krin-san]

@dannyhertz I patched SEGUtils.m in place, right in Pods folder to see if that's enough. On Monday I can prepare a PR if no one wants to make that earlier.

[krin-san]

@dannyhertz it took some time to prioritize and test that, but PR is ready.
Could you check if that fixes your issue too? To install the fork change your Podfile like that:

- pod 'Analytics'
+ pod 'Analytics', :git => 'https://github.com/krin-san/analytics-ios.git', :branch => 'bugfix/launch_with_deeplink'

[migs647]

We're looking at this today

[sanhue0302]

I think this is same problem as #959 ?

[darrenspriet]

Any idea when this fix is going in?

[bsneed]

Should have this resolved tomorrow. #959 shed a little more light on the issue.

[bsneed]

Oops, closed by mistake. Meant to hit the comment button.

[darrenspriet]

Issue I am having is opening a URL from a widget in the non-running state. I get the crashed described above. And adding this line actually fixes it [obj isKindOfClass:[NSURL class]] | as described. Is this fix or another fix resolving this issue in a release available?

[sanhue0302]

Doesn't NSURL confirms to SEGSerializable?
There is a category in SEGAnalyticsUtils.m

I think It will return YES in SEGUtil.m:509
in my case , the problem will be fixed by change code as below:

        if ([aValue conformsToProtocol:@protocol(SEGSerializableDeepCopy)]) {
            theCopy = [aValue serializableDeepCopy:mutable];
        // change order of conformsToProtocol to SEGSerializable and NSCopying
        } else if ([aValue conformsToProtocol:@protocol(SEGSerializable)]) {
            theCopy = [aValue serializeToAppropriateType];
        } else if ([aValue conformsToProtocol:@protocol(NSCopying)]) {
            theCopy = [aValue copy];
        } else {
            theCopy = aValue;
        }

[darrenspriet]

Awesome, I see the change in 4.1.0. I was trying to find which release the change went into. Thank you for clarifying!

[bsneed]

Fixed! Will be on master to try out shortly. Release coming soon.

[bstillitano]

This is still happening with iOS 16 using analytics-ios 4.1.6