Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add top level anonymous id method #78

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

wenxi-zeng
Copy link
Contributor

  • add top level anonymous id method
  • add top level version method
  • add unit tests for the above

@codecov-commenter
Copy link

Codecov Report

Merging #78 (e12ee5c) into main (98966a0) will decrease coverage by 0.01%.
The diff coverage is 70.83%.

@@             Coverage Diff              @@
##               main      #78      +/-   ##
============================================
- Coverage     77.83%   77.82%   -0.02%     
- Complexity      427      436       +9     
============================================
  Files            64       64              
  Lines          5427     5451      +24     
  Branches        684      688       +4     
============================================
+ Hits           4224     4242      +18     
  Misses          679      679              
- Partials        524      530       +6     
Impacted Files Coverage Δ
.../analytics/kotlin/core/compat/JavaAnalyticsTest.kt 67.04% <50.00%> (-0.27%) ⬇️
...om/segment/analytics/kotlin/core/AnalyticsTests.kt 78.27% <63.63%> (-0.58%) ⬇️
...ava/com/segment/analytics/kotlin/core/Analytics.kt 76.28% <85.71%> (+0.44%) ⬆️
...ment/analytics/kotlin/core/compat/JavaAnalytics.kt 68.08% <100.00%> (+1.41%) ⬆️
...n/java/com/segment/analytics/kotlin/core/Events.kt 46.23% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98966a0...e12ee5c. Read the comment docs.

Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wenxi-zeng wenxi-zeng merged commit c88bd1c into main Mar 17, 2022
@wenxi-zeng wenxi-zeng deleted the wenxi/add-top-level-anonymousId-method branch March 17, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants