GA: Add checkout options to the checkout step completed event hit #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsamson
force-pushed
the
gps/ecomm
branch
2 times, most recently
from
a6c42c5
to
48f6373
Compare
gpsamson
changed the title
briemcnally
approved these changes
Feb 13, 2020
| window.ga(self._trackerName + 'send', 'event', 'Checkout', 'Option', { | ||
| step: props.step || 1, | ||
| option: options | ||
| }); |
There was a problem hiding this comment.
LGTM! Do we know if there is any negative side effects of sending the step and option twice here? I don't see any based off your tests but was just wondering if you noticed anything in your local testing?
There was a problem hiding this comment.
Negative, not that I've noticed in my end-to-end tests. I have a customer testing this first so I'll give them some extra time to look at reports and confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://segment.atlassian.net/browse/STRATCONN-41