-
Notifications
You must be signed in to change notification settings - Fork 736
Replacing duojs with npm and then updating the core library and way integrations are included. #514
Conversation
This is to update the Analytics.js build repo with all the changes to the core and integrations repos. Those changes actually broke the older tags of this repo so this fix is fairly high priority since building off master is now broken. I can go into more detail if needed. Thanks for the consideration. |
Looks like tests are failing:
I may need some help here. |
0b040d6
to
c7cde11
Compare
…ntegrations are included. This is following all the recent work being done in analytics.js-core, analytics.js-integration, and an example integration (GTM).
c7cde11
to
53a33ff
Compare
Got the build passing but just made a |
+1 |
@rcline this is awesome — thank you! I know @ndhoule had some big plans for the next major release of public analytics.js once we finish our internal migration. essentially removing the implicit dependence on all the integrations and providing better options for building custom builds through npm/browserify with only the ones you want. i'll let him follow up here! |
@rcline Thanks a lot for this work! We're currently in the process of rolling Browserified analytics.js out across the Segment product and updating open-source Analytics.js to match will be my first order of work after that's completed. Definitely happy to jump in here and help get tests passing. We're aiming to have our rollout finished this week and I'll follow up shortly thereafter. |
@ndhoule Do you think this might get merged in the near future? I'm only asking because we are wondering if we should merge this locally to fix the issues on our wrap of this package or wait few days. |
Thanks @sperand-io, @ndhoule, I am very glad this is getting attention and all the great work being done to update this collection of tooling. My company is using a version of this branch and it is working very well. Feel free to use this as a starting point for the work you have planned or start off Much thanks! |
@arrygoo I would recommend either forking yourself or using my fork/branch for now. This will get you unblocked in the short term. Also, since this is a "Build repo" with the output being a single file it should be fairly painless to upgrade when segment has made the official v3 release. |
Thanks @rcline, I'm using your fork/branch on https://github.com/okgrow/analytics until v3 release. |
|
hola. any news on this issue? |
Just got the same build error today and found this PR Any plans to merge it into master? |
@ayb I have not heard anything from the segment team lately, I am sure they have their hands full. I would recommend just using this fork/branch (or fork off this one yourself, adding/removing your specific integrations) for now until an update is made. Since it is just a building repo with a single artifact file it should be easy enough to swap out once an official update is released. Let me know if you have questions! |
@rcline Got it working this morning. Thanks :) |
Hi guys, any update? It seems that this repository is not very often updated |
Using this fork as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with updating the minifier. This should fix the minified bundles not being property minified.
This is following all the recent work being done in analytics.js-core, analytics.js-integration, and an example integration (GTM).