This repository has been archived by the owner on Apr 28, 2022. It is now read-only.
Mixpanel name_tag should prefer using email over user ID #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically
userID
is something unfriendly like a number or arbitrary string. In your docsidentity()
example you happen to use their email as the user id, which is fine, but I think its perhaps more common for people to pass in their truly unique id (which emails may not be) toidentify()
Before,
mixpanel.name_tag()
passed the ID -- the change passes the email if possibleFrom https://mixpanel.com/docs/integration-libraries/javascript-full-api#name_tag it says "human-readable", which an email is, but an ID often isn't.