Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Mixpanel name_tag should prefer using email over user ID #60

Merged
merged 2 commits into from
Jan 22, 2013

Conversation

philfreo
Copy link
Contributor

Typically userID is something unfriendly like a number or arbitrary string. In your docs identity() example you happen to use their email as the user id, which is fine, but I think its perhaps more common for people to pass in their truly unique id (which emails may not be) to identify()

Before, mixpanel.name_tag() passed the ID -- the change passes the email if possible

From https://mixpanel.com/docs/integration-libraries/javascript-full-api#name_tag it says "human-readable", which an email is, but an ID often isn't.

@philfreo
Copy link
Contributor Author

haven't got the testing env setup locally yet so the build is failing, but hopefully you get the gist of what i'm going for here

@ianstormtaylor
Copy link
Contributor

Yup I gotcha, good call. Merging it in now

@ianstormtaylor ianstormtaylor merged commit b11442e into segmentio:master Jan 22, 2013
@philfreo philfreo mentioned this pull request Jan 24, 2013
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants