Cleanup from merges/reverts of arm64 targets #326
Conversation
|
@asaf-erlich @emmy-byrne-segment (I'm not sure if you're the right people to ping) can we do anything to help review this PR? I'd like to get ARM binaries available. If there are any tests we need to add or verifications that need to be made, I'm happy to do some gunt work 😄 |
|
@pop @cmayeuxLob we are having internal conversations with the team about this topic and will try to respond as soon as we can. |
|
Hello @pop @cmayeuxLob we're going to go ahead and merge this PR. Then I will try to create a release to trigger the new binaries are all built AND get uploaded to github (only gets exercised on a new tag). If that succeeds everything is fine. If it fails we will discuss the next steps required but don't know yet what blockers might show up. 🤞 that everything just works. |
|
Circle build is running that you probably don't have access to: https://app.circleci.com/pipelines/github/segmentio/chamber/118/workflows/3527bfca-5122-4ddf-9d6c-8385c26948c7 |
|
It worked! I see the binaries attached to the releases tag, can you check if they work on their respective platform? |
Woot, thanks @asaf-erlich ! Just verified that the linux-arm64 binary works! |
There was a publish-github-arm64-deb target under publish-github which no longer exists, and publish-github-linux-arm64 exists but isn't in PHONY. Cleaning that up, as I'd love to have a linux/arm64 package of chamber if there's a release sometime soon for use on graviton instances!