Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Used to work great but not anymore #57

Open
PManager1 opened this issue Apr 30, 2018 · 18 comments
Open

Used to work great but not anymore #57

PManager1 opened this issue Apr 30, 2018 · 18 comments

Comments

@PManager1
Copy link

when i try to click buttons on a page, it doesn capture it..

Please help me I really need it to work

image

image

const Nightmare = require('nightmare')
const nightmare = Nightmare({ show: true })

nightmare

.end()
.then(function (result) {
console.log(result)
})
.catch(function (error) {
console.error('Error:', error);
});
restart

@czechdave
Copy link

Just tried it out in the latest chrome and no action ever gets captured

@ChristosChristofidis
Copy link

Did you solve this?

@PManager1
Copy link
Author

@ChristosChristofidis nope

@czechdave
Copy link

@ChristosChristofidis solved by deleting the plugin

@ThomasDotCodes
Copy link

Same issue here... I just installed the plugin for the first time on fresh install of chrome as well. Not sure if @czechdave is suggesting to delete and reinstall -- but that didn't have any effect.

@danyalaytekin
Copy link

danyalaytekin commented May 24, 2018

For me, it depends on the site. For example it works on github.com but not www.bbc.co.uk/news.

@zacharyabresch
Copy link

Chiming in because I really want to use this plugin heavily, now, but it seems to be severely broken. Some environment details:

  • OS: Mac High Sierra - 10.13.4 (17E202)
  • Browser: Google Chrome Version 67.0.3396.62 (Official Build) (64-bit)

I've tried to use this on several sites (localhost projects, Github, Medium, Bugsnag) and I've only gotten it to record anything 2 times. Both were after restarting Chrome but now that isn't even working (on the same sites).

Is there anything else I can provide to assist in debugging this? Any workarounds to try? A fix in the pipeline?

@zacharyabresch
Copy link

zacharyabresch commented May 30, 2018

Follow-up: The extension icon does highlight green when starting and turns black when stopping. I get the script pop-up but it contains the default, empty script. I can restart but no activity gets recorded.

const Nightmare = require('nightmare')
const nightmare = Nightmare({ show: true })

nightmare

.end()
.then(function (result) {
  console.log(result)
})
.catch(function (error) {
  console.error('Error:', error);
});

@EvsWorld
Copy link

EvsWorld commented May 31, 2018 via email

@rschwabco
Copy link

I'm also interested in having this plugin work again. I'm seeing it throws some errors when not on github.com (was able to make it work there). Is this project being actively worked on? If so, can this issue be escalated? It seems to make the extension unusable currently.

@CarlosDomingues
Copy link

Same issue, nothing gets captured besides typing.

@MynockSpit
Copy link

MynockSpit commented Jul 22, 2018

Hey guys, figured out the issue. The script that registers "events" doesn't start until after you go to a new page or refresh. Until this can get fixed, this should work:

  1. Start Daydream recording.
  2. Refresh the page or go to a new page using the same window/tab.
  3. Use as per normal.

@zacharyabresch
Copy link

zacharyabresch commented Jul 23, 2018

WOW!!!! @MynockSpit you 🚀! I can confirm that this works. I tested it with a localhost domain, Github, & Google:

const Nightmare = require('nightmare')
const nightmare = Nightmare({ show: true })

nightmare
.goto('https://github.com/')
.click('.my-3 > .Box-body > .list-style-none > :nth-child(1) > .width-full > .mb-2 > :nth-child(2)')
.click('.reponav > :nth-child(2) > .js-selected-navigation-item')
.end()
.then(function (result) {
  console.log(result)
})
.catch(function (error) {
  console.error('Error:', error);
});
const Nightmare = require('nightmare')
const nightmare = Nightmare({ show: true })

nightmare
.goto('https://www.google.com/')
.type('#lst-ib', 'Daydream extension')
.click(':nth-child(8) > :nth-child(1) > .rc > .r > a')
.goto('https://github.com/segmentio/daydream')
.end()
.then(function (result) {
  console.log(result)
})
.catch(function (error) {
  console.error('Error:', error);
});

This seems like it could be a pretty straightforward fix but I've never peeked at the Daydream source so I really have no idea what the LOE would be. Either way, this is awesome and I'm gonna go automate all the things now.

BTW, I wouldn't consider this issue "closed" but that's really up to the repo owners.

@zacharyabresch
Copy link

There are still some serious issues with this extension picking up actions while navigating pages. Especially SPAs ... I rarely get more than one or two clicks before the tracking bails out. Pretty disappointing but hey, at least it's working so it's a step forward.

@MynockSpit
Copy link

Could be two things:

  1. Clicks are only currently registered on button and inputs. Maybe you have onClick on divs?
  2. goto takes a while to get registered -- seems like the page has to completely settle before it registers a goto.

And yeah, they're both pretty simple fixes. We just need someone to approve and merge PRs. :)

@zacharyabresch
Copy link

Good ideas, both. My testing was quick & dirty so I’ll spend a bit more time when I’ve got it.

@interbiznw
Copy link

Looks kinda unmaintained? Time to fork and get some fixes in motion https://github.com/interbiznw/daydream

@lvl99
Copy link

lvl99 commented Jan 14, 2019

Any news?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests