Implementation of session timeout in V1 SASL Authentication #1227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1093
This PR aims to interpret the session timeout in the SaslAuthenticate V1 Response. Considering that both
saslAuthenticateRequestV0
andsaslAuthenticateResponseV0
are only used in when we're working with V1 requests, i've decided to rename these tosaslAuthenticateRequestV1
andsaslAuthenticateResponseV1
and bring in the addition ofsession_lifetime_ms
V1 Response:
https://kafka.apache.org/protocol.html#The_Messages_SaslAuthenticate
I've also taken inspiration from https://github.com/twmb/franz-go/blob/a1a2a452c33e53c177792b251c523786c4d9fa27/pkg/kgo/broker.go#L373 to check the expiry on read, at a staggered interval at around 90-90% of the session_lifetime_ms