This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Allow key value metadata to be set after writing rows #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaub
force-pushed
the
update-key-value-metadata
branch
from
41a15b5
to
0be014a
Compare
writer.go
Outdated
| // keys. This may create incompatibilities with other parquet libraries, or may | ||
| // cause some key/value pairs to be lost when open parquet files written with | ||
| // repeated keys. We can revisit this decision if it ever becomes a blocker. | ||
| func (w *Writer) KeyValueMetadata(key, value string) { |
There was a problem hiding this comment.
How about renaming to Set* to better communicate that the previous value will be overwritten?
We could also imagine having an Add* method for cases where the application needs to associated multiple values to a key.
Suggested change
| func (w *Writer) KeyValueMetadata(key, value string) { | |
| func (w *Writer) SetKeyValueMetadata(key, value string) { |
There was a problem hiding this comment.
Updated in the latest commit.
tschaub
force-pushed
the
update-key-value-metadata
branch
from
0be014a
to
98a5424
Compare
Latest commit adds the method to |
achille-roussel
approved these changes
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
SetKeyValueMetadatamethod to the writer to allow key value file metadata to be updated after the writer is created. This allows for writing metadata that might be derived from the rows without having to buffer all the rows before creating the writer.Fixes #397.