Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Overview Docs #5355

Closed
wants to merge 17 commits into from
Closed

Source Overview Docs #5355

wants to merge 17 commits into from

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Created source overview docs at request of PM

Merge timing

ASAP!!

Related issues (optional)

sarahrudy and others added 15 commits September 5, 2023 12:54
@sarahrudy
Update Page method paragraph: GTM
6ade30b 
- reword paragraph where we let customers know that they must call the page method for GTM to load
- the wording was somewhat unclear, so I made a simple change by rearranging the sentence
@stayseesong
add destinations from npm
79597f4
@rohantryskybox
1Flow iOS doc update
ca3a8d3
@rohantryskybox
Specified where to find 1flow project key
518003d
@bcaudillo
Update AppsFlyer Device Id Section
4c3dbc7
@varadarajan-tw
[STRATCONN-3072]-Update pinterest conversions doc
f02888e
@stayseesong
Apply suggestions from code review
466b78e
@rohantryskybox
Added installation instruction for both platform
b62a21c
@rohantryskybox
Address requested changes
4986aad
@forstisabella
Merge pull request #5322 from rohantryskybox/1Flow-iOS
097e6f0 
1Flow iOS doc update
@stayseesong
Merge pull request #5330 from segmentio/bcaudillo-patch-7
60badde 
Update AppsFlyer Device Id Section
@stayseesong
Merge pull request #5341 from segmentio/fix-pinterest-docs
776f7e3 
[STRATCONN-3072]-Update pinterest conversions doc
@stayseesong
Merge pull request #5315 from segmentio/DOC-727
961fc59 
add destinations from npm
@stayseesong
Merge pull request #5297 from segmentio/sarahrudy-patch-6
7659970 
Update Page method paragraph: GTM
@forstisabella
init source overview section
a27ff9d
@forstisabella forstisabella requested a review from a team as a code owner September 15, 2023 19:28
@forstisabella forstisabella requested review from pwseg and removed request for a team September 15, 2023 19:28
@netlify
Copy link

netlify bot commented Sep 15, 2023

✅ Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit a27ff9d
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6504b0570ed1ee0008d1b399
😎 Deploy Preview https://deploy-preview-5355--segment-docs.netlify.app/connections/sources
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 775cc71
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6504ba2871a135000883f3ed
😎 Deploy Preview https://deploy-preview-5355--segment-docs.netlify.app/connections/sources
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@forstisabella forstisabella changed the base branch from develop to master September 15, 2023 21:07
@forstisabella
Copy link
Contributor Author

Merged in #5357.

@forstisabella forstisabella deleted the source-overview-docs branch September 15, 2023 21:59
@forstisabella forstisabella restored the source-overview-docs branch September 29, 2023 20:37
@forstisabella forstisabella deleted the source-overview-docs branch September 29, 2023 20:40
@forstisabella forstisabella mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwseg pwseg pwseg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@forstisabella @pwseg @sarahrudy @stayseesong @rohantryskybox @bcaudillo @varadarajan-tw