Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engage content updates [DOC-733] #5411

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Engage content updates [DOC-733] #5411

merged 9 commits into from
Mar 20, 2024

Conversation

rchinn1
Copy link
Contributor

@rchinn1 rchinn1 commented Sep 25, 2023

Proposed changes

  • Added dynamic sender and content validation content to the Engage docs.

Merge timing

  • Once approved by docs/PM

Related issues (optional)

DOC-733

@rchinn1 rchinn1 added the content-update updates to content that are not new features, includes grammar fixes, added notes label Sep 25, 2023
@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit f9445a4
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6511b74c7da35600082a84bb
😎 Deploy Preview https://deploy-preview-5411--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 1a2df98
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6516ff6d6bbb850008995d95
😎 Deploy Preview https://deploy-preview-5411--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rchinn1 rchinn1 marked this pull request as ready for review September 29, 2023 23:00
@rchinn1 rchinn1 requested a review from pwseg as a code owner September 29, 2023 23:00
@pwseg pwseg merged commit c30f541 into develop Mar 20, 2024
3 checks passed
@pwseg pwseg deleted the Engage-content-updates branch March 20, 2024 18:41
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@forstisabella forstisabella mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants