Delivery Overview discard table improvements #6237
Conversation
…e to fix anything else ffs
need to troubleshoot the following items tomorrow: - Failed on Ingest section breaks the sidebar (too wide) - missing a </td> somewhere - leads to glitching in the header
forstisabella
added
the
content-update
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
forstisabella
changed the base branch from
develop
to
delivery-overview-ga-one-off
|
Will come back to review this |
| table = document.getElementById("settingsTable"); | ||
| tr = document.getElementsByClassName("settingRow"); | ||
| for (i = 0; i < tr.length; i++) { | ||
| samp = tr[i].getElementsByTagName("samp")[0]; |
There was a problem hiding this comment.
if you wanna filter by both columns, you'll prob need to wrap the Discard Reason entries with a different tag but similar to how you did with <samp> then check for it in txtValue also. Or maybe assign it to a specific id like <td id=discardTitle.. if that works
There was a problem hiding this comment.
you could try it on a few entries first to make sure something like that would work then apply a search + replace all
src/connections/sources/catalog/libraries/server/http-api/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/server/http-api/index.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,42 @@ | |||
| <table> | |||
There was a problem hiding this comment.
Just for my own knowledge, do include tables have to be HTML instead of markdown?
There was a problem hiding this comment.
no, they can be markdown, most tables on the site are. but with the search and filtering functionality this table had to be formatted with HTML
Co-authored-by: Casie Oxford <coxford@twilio.com>
forstisabella
changed the base branch from
delivery-overview-ga-one-off
to
master
Proposed changes
Added a table of all common delivery overview discard errors
Merge timing
When Delivery Overview (Streaming Connections) goes GA
Related issues (optional)
https://segment.atlassian.net/browse/DOC-842