Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acoustic Catalog initial submit #6425

Merged

Conversation

KWLandry-acoustic
Copy link
Contributor

Initial Catalog entry for Acoustic (Actions) Destination

Merge timing

@KWLandry-acoustic KWLandry-acoustic requested a review from a team as a code owner April 23, 2024 12:44
@KWLandry-acoustic KWLandry-acoustic requested review from pwseg and removed request for a team April 23, 2024 12:44
@pwseg pwseg requested a review from tcgilbert April 23, 2024 17:44
@KWLandry-acoustic
Copy link
Contributor Author

Hi Folks,
As it's been two weeks without an update, can we get an idea of the timing to complete a review?
Thanks,

KWLandry-acoustic and others added 3 commits May 7, 2024 13:26
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these changes are made I will go ahead and approve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KWLandry-acoustic still seeing pic1 2 and 3 in the files tab. Can you try removing once more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, should be done, again,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, let's see if it sticks,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I'm getting the confirmation of Delete, but navigating out and back I see them still there,
Will try again,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the delete occurred, I committed each in turn versus lumping all in one,

KWLandry-acoustic and others added 9 commits May 14, 2024 11:18
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
KWLandry-acoustic and others added 6 commits May 14, 2024 12:02
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
…ions-acoustic/index.md

Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
@KWLandry-acoustic
Copy link
Contributor Author

KWLandry-acoustic commented May 14, 2024 via email

@tcgilbert
Copy link
Contributor

@KWLandry-acoustic thanks for making those updates. @pwseg from our docs team will give a final review and get this through for you.

Do you have a timeline for when you want your integration to go live? We have everything needed on our end. As long as you have tested your integration and ensured it is behaving as expected we can move it into Public Beta.

@KWLandry-acoustic
Copy link
Contributor Author

KWLandry-acoustic commented May 14, 2024 via email

@pwseg pwseg added the new-integration Added a new source or destination label May 15, 2024
@pwseg
Copy link
Contributor

pwseg commented May 15, 2024

@tcgilbert Merging this now, it'll be live after our regular Thursday deploy.

@pwseg pwseg merged commit c3e8235 into segmentio:develop May 15, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants