Improve cross-rack replication checks (#138)
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[[ … ]]` is a bashism and doesn’t work with all `sh`.
If `--validate-only` is set the number of racks needed is ignored. If there are broker connections, use the actual number of racks in the cluster.
petedannemann
approved these changes
Jul 11, 2023
|
@joewreschnig thanks for your contribution! I just cut release 1.10.0 and included this in it https://github.com/segmentio/topicctl/releases/tag/v1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--validate-onlyis set the number of racks needed is ignored.If there are broker connections, use the actual number of racks in the
cluster.
Use
/bin/bashforset_up_net_alias.sh.[[ … ]]is a bashism and doesn’t work with allsh.