Upgrade to go 1.24.5 (#2357)

Upgrade the go module to 1.24.5 and reflect across docker builds.

Upgrade golangci-lint and fix many many lint issues

Upgrade all CI workflows to go 1.24 consistent with go module

Fix golangci-lint config to comply with schema

Author: masih

.github/workflows/codeql.yml

@@ -26,7 +26,7 @@ jobs:
         uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.21
+          go-version: 1.24
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2

.github/workflows/compatiblity_check.yml

@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.21
+          go-version: 1.24
 
       - name: Check Latest Dependencies
         run: |

.github/workflows/eth_blocktests.yml

@@ -46,7 +46,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.21
+          go-version: 1.24
 
       - name: Clone ETH Blocktests
         run: |

.github/workflows/golangci.yml

@@ -19,11 +19,10 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.21
+          go-version: 1.24
       - uses: actions/checkout@v3
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v8
         with:
-          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.60.1
+          version: v2.4.0
           args: --timeout 10m0s

.github/workflows/integration-test.yml

@@ -148,7 +148,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.21
+          go-version: 1.24
 
       - name: Start 4 node docker cluster
         run: make clean && INVARIANT_CHECK_INTERVAL=10 ${{matrix.test.env}} make docker-cluster-start &

.github/workflows/mock_balances_build.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.21
+          go-version: 1.24
 
       - name: Build with Mock Balances
         run: make install-mock-balances

.github/workflows/unit_tests.yml

@@ -20,7 +20,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: "1.21"
+          go-version: "1.24"
       - uses: actions/checkout@v3
       - uses: technote-space/get-diff-action@v6
         with:
@@ -55,7 +55,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.21
+          go-version: 1.24
 
       # Download all coverage reports from the 'tests' job
       - name: Download coverage reports

.golangci.yml

@@ -1,50 +1,32 @@
+version: "2"
 run:
   tests: false
-#   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 10m
   build-tags:
     - codeanalysis
 
 linters:
-  disable-all: true
+  default: none
   enable:
     - bodyclose
-    # - depguard ## see https://github.com/golangci/golangci-lint/issues/3906
     - dogsled
-    - exportloopref
     - errcheck
     - goconst
-    # - gocritic
-    - gofmt
-    - goimports
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
-    # - nakedret
     - prealloc
     - staticcheck
-    # - structcheck ## author abandoned project
-    - stylecheck
-    # - revive
-    # - typecheck
     - unconvert
-    # - unused
-    # - unparam
     - misspell
-    # - nolintlint ## does not work with IDEs like VSCode which automatically insert leading spaces
+  exclusions:
+    rules:
+      - linters:
+          - gosec
+        text: "Use of weak random number generator"
 
-issues:
-  exclude-rules:
-    - text: "Use of weak random number generator"
-      linters:
-        - gosec
-    - text: "ST1003:"
-      linters:
-        - stylecheck
-    # FIXME: Disabled until golangci-lint updates stylecheck with this fix:
-    # https://github.com/dominikh/go-tools/issues/389
-    - text: "ST1016:"
-      linters:
-        - stylecheck
+formatters:
+  enable:
+    - gofmt
+    - goimports

Dockerfile

@@ -1,5 +1,5 @@
 # ---------- Builder ----------
-FROM golang:1.23.7 AS go-builder
+FROM golang:1.24.5 AS go-builder
 WORKDIR /app/sei-chain
 
 RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates wget && \

app/app.go

@@ -949,7 +949,7 @@ func New(
 			tmos.Exit(err.Error())
 		}
 
-		ctx := app.BaseApp.NewUncachedContext(true, tmproto.Header{})
+		ctx := app.NewUncachedContext(true, tmproto.Header{})
 		if err := app.WasmKeeper.InitializePinnedCodes(ctx); err != nil {
 			tmos.Exit(fmt.Sprintf("failed initialize pinned codes %s", err))
 		}
@@ -1871,7 +1871,7 @@ func (app *App) RegisterAPIRoutes(apiSvr *api.Server, apiConfig config.APIConfig
 
 // RegisterTxService implements the Application.RegisterTxService method.
 func (app *App) RegisterTxService(clientCtx client.Context) {
-	authtx.RegisterTxService(app.BaseApp.GRPCQueryRouter(), clientCtx, app.BaseApp.Simulate, app.interfaceRegistry)
+	authtx.RegisterTxService(app.GRPCQueryRouter(), clientCtx, app.Simulate, app.interfaceRegistry)
 }
 
 func (app *App) RPCContextProvider(i int64) sdk.Context {
@@ -1893,7 +1893,7 @@ func (app *App) RPCContextProvider(i int64) sdk.Context {
 
 // RegisterTendermintService implements the Application.RegisterTendermintService method.
 func (app *App) RegisterTendermintService(clientCtx client.Context) {
-	tmservice.RegisterTendermintService(app.BaseApp.GRPCQueryRouter(), clientCtx, app.interfaceRegistry)
+	tmservice.RegisterTendermintService(app.GRPCQueryRouter(), clientCtx, app.interfaceRegistry)
 	txConfigProvider := func(height int64) client.TxConfig {
 		if app.ChainID != "pacific-1" {
 			return app.encodingConfig.TxConfig
@@ -1989,7 +1989,7 @@ func (app *App) checkTotalBlockGas(ctx sdk.Context, txs [][]byte) bool {
 			gasWanted = feeTx.GetGas()
 		}
 
-		if int64(gasWanted) < 0 || int64(totalGas) > math.MaxInt64-int64(gasWanted) {
+		if int64(gasWanted) < 0 || int64(totalGas) > math.MaxInt64-int64(gasWanted) { // nolint:gosec
 			return false
 		}
 
@@ -2007,11 +2007,11 @@ func (app *App) checkTotalBlockGas(ctx sdk.Context, txs [][]byte) bool {
 			totalGas += gasWanted
 		}
 
-		if totalGasWanted > uint64(ctx.ConsensusParams().Block.MaxGasWanted) {
+		if totalGasWanted > uint64(ctx.ConsensusParams().Block.MaxGasWanted) { //nolint:gosec
 			return false
 		}
 
-		if totalGas > uint64(ctx.ConsensusParams().Block.MaxGas) {
+		if totalGas > uint64(ctx.ConsensusParams().Block.MaxGas) { //nolint:gosec
 			return false
 		}
 	}