Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefetch and cache images #16

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Prefetch and cache images #16

merged 3 commits into from
Dec 14, 2017

Conversation

shamenchens
Copy link
Contributor

@shamenchens shamenchens commented Dec 14, 2017 •
edited
Loading

This pr will try to cover following changes:

  • Use Unsplash API to get 15 images every day, images will be prefetched and cached.
  • Cache will invalid on new daily images arrive.
  • Give attribution for image source.
  • Fix preference's bug.

Please note first time loading speed may still slow.

A quick demo: https://www.youtube.com/watch?v=JLV8ahgnxLY
Try it on: https://addons.mozilla.org/en-US/firefox/addon/yuman-prerelease/

dwi2
dwi2 approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@dwi2 dwi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@shamenchens shamenchens merged commit 2eb79b8 into seiyugi:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwi2 dwi2 dwi2 approved these changes

@mpizza mpizza Awaiting requested review from mpizza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamenchens @dwi2