-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify a Minimum Supported Rust Version (MSRV) for #198
Comments
In principal, the But not for some small-ish CLI tool. The second PR helps most definitely, but still I think it's good to at least know the MSRV, and to specify it in the |
Makes sense. The main benefit that I see of the toolchain config file is that it will automatically grab the toolchain that is known to work which means that everyone ends up building the tool with the same Rust version. We have people who aren't familiar with Rust building the SDK from source so it would help them as well if their Rust version installed doesn't match what the tool needs. Anyways, that's a separate issue. I've made #200 specifying 1.79.0 as the minimum version since that's what I've used to compile and test the SDK. Let me know if that works for you and I can close the issue. |
If you can't upgrade to 1.79.0 though I can try 1.77 and drop the minimum version to that if everything works. |
I highly recommend to also verify the MSRV in the CI, see https://doc.rust-lang.org/cargo/guide/continuous-integration.html#verifying-rust-version for an example on how to do that.
That would be very very kind of you, I don't want to ask for this but it would help me if you'd did that.
Only for those using
At least the promise from the Rust advertisement is: no existing code will break, unless one upgrades the edition of the crate. There are some very few counterexamples, but in general you should not have to worry about your code breaking with a newer toolchain. A lot of effort on the Rust project is spent on assuring this promise. W/r/t to running a toolchain that is is too old, well there the MSRV as specified in the |
Two notes:
|
I can't build 1.4.0 with rustc 1.77.2 due to a lifetime issue. With a newer rustc version it works. I think it would be best to just clearly document this in the
Cargo.toml
and to use a tool likecargo-hack
orcargo-msrv
to check that the claim from theCargo.toml
holds true.The text was updated successfully, but these errors were encountered: