Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libplatsupport: SPI on Exynos does not use a 180 degree phase feedback #2

Closed
agacek opened this issue Jul 25, 2016 · 1 comment
Closed

Comments

@agacek
Copy link
Contributor

agacek commented Jul 25, 2016

The relevant code is here:

https://github.com/seL4/util_libs/blob/master/libplatsupport/src/mach/exynos/spi.c#L201

The comment says to use a 180 degree phase feedback, but the code sets no phase feedback. For a 180 degree phase feedback it should be v = (0x2 << FB_CLK_SEL_SHF);. The SPI for the CAN controller on the HACMS Odroid/daughterboard platform does not work correctly without a phase feedback (90, 180, or 270 would all work). Please set the phase feedback to 180 degrees or make it configurable when the SPI is initialized.

agacek added a commit to smaccm/util_libs that referenced this issue Jul 27, 2016
@agacek
Copy link
Contributor Author

agacek commented Dec 15, 2016

Fixed 808f1a0

@agacek agacek closed this as completed Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant