Skip to content

Firefox options unnecessary prefix #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

vaswix
Copy link

@vaswix vaswix commented Nov 26, 2024

Hi, When adding arguments to specify the path to the firefox profile, you need to specify -profile and path/to/profile separated by commas, otherwise the profile does not open. I also tried -profile=path/to/profile and --profile=path/to/profile, but this does not open the profile, so the only option that works for firefox, I have this firefox_arg='-profile,path/to/profile', but since in the same way, when checking firefox_arg_item, prefix '--' is added to the beginning of the path, which is why firefox cannot find the folder, the result is the string '--path/to/profile' because of this, I suggest checking that the string is the path and not adding prefix '--'

@mdmintz
Copy link
Member

mdmintz commented Nov 26, 2024

That's not the optimal way to solve the problem you're trying to solve.

  • Your code has flake8 linter issues. (Eg. Line length above accepted limit.)
  • Your code is setting a variable to itself.
  • You're not utilizing os.sep to simplify file-separator differences between different OS.
  • You added : into the conditional where it shouldn't be included (Eg. https://stackoverflow.com/a/77901568/7058266)

The original problem has been resolved in 4.33.0 with this commit: 9636868

Also, I've been moving toward the principles outlined in https://github.com/readme/featured/how-open-is-open-source:
"Open-Source, not Open-Contribution" (with some special exceptions).

@mdmintz mdmintz closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants