Skip to content

Commit 047ab5f

Browse files
committed
Remove automatic installation of the SafariDriver in Java.
Moving forward, users will be expected to manually install the extension. This change is response to architectural changes introduced with Safari 7 that broke auto-installation. Starting with the next Selenium release, SafariDriver.safariextz will be posted along with the other Selenium release artifacts. The extension does not currently auto-update; we may yet add support for this. This change also removes support for installing additional extensions via SafariOptions (for the same reasons we no longer support installing the driver itself). All extension related methods in SafariOptions have been deprecated, are no-ops, and will be removed in the next+1 release. Fixes issue 8514
1 parent 3ebec51 commit 047ab5f

File tree

9 files changed

+24
-756
lines changed

9 files changed

+24
-756
lines changed

java/client/src/org/openqa/selenium/safari/SafariDriverCommandExecutor.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ class SafariDriverCommandExecutor implements CommandExecutor {
6161

6262
private static final Logger log = Logger.getLogger(SafariDriverCommandExecutor.class.getName());
6363

64-
private final SafariExtensions safariExtensions;
6564
private final SafariDriverServer server;
6665
private final BrowserLocator browserLocator;
6766
private final SessionData sessionData;
@@ -74,7 +73,6 @@ class SafariDriverCommandExecutor implements CommandExecutor {
7473
* @param options The {@link SafariOptions} instance
7574
*/
7675
SafariDriverCommandExecutor(SafariOptions options) {
77-
this.safariExtensions = new SafariExtensions(options);
7876
this.server = new SafariDriverServer(options.getPort());
7977
this.browserLocator = new SafariLocator();
8078
this.sessionData = SessionData.forCurrentPlatform();
@@ -94,7 +92,6 @@ synchronized void start() throws IOException {
9492

9593
server.start();
9694

97-
safariExtensions.install();
9895
if (cleanSession) {
9996
sessionData.clear();
10097
}
@@ -161,14 +158,6 @@ synchronized void stop() {
161158

162159
log.info("Stopping server");
163160
server.stop();
164-
165-
try {
166-
log.info("Uninstalling extensions");
167-
safariExtensions.uninstall();
168-
} catch (IOException e) {
169-
throw new WebDriverException("Unable to uninstall extensions", e);
170-
}
171-
172161
log.info("Shutdown complete");
173162
}
174163

0 commit comments

Comments
 (0)