If the first rm -rf attempt fails to delete everything, make

a second attempt before reporting an error to the caller.

Sometimes we fail to delete all of the contents of Firefox’s temporary profile on quit. I think this is caused by a race: we attempt the `rm -rf` before Firefox has fully shutdown, and files get rewritten after we delete them.

Author: jleyba

javascript/node/selenium-webdriver/io/index.js

@@ -37,13 +37,22 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
  */
 exports.rmDir = function(path) {
   return new promise.Promise(function(fulfill, reject) {
-    rimraf(path, function(err) {
-      if (err) {
-        reject(err);
-      } else {
-        fulfill();
-      }
-    });
+    var numAttempts = 0;
+    attemptRm();
+    function attemptRm() {
+      numAttempts += 1;
+      rimraf(path, function(err) {
+        if (err) {
+          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+            attemptRm();
+            return;
+          }
+          reject(err);
+        } else {
+          fulfill();
+        }
+      });
+    }
   });
 };