[rust] Use escaped browser path (required by wmic commands) in Selenium Manager (#12304)

Author: bonigarcia

rust/README.md

@@ -32,7 +32,7 @@ Options:
       --browser-version <BROWSER_VERSION>
           Major browser version (e.g., 105, 106, etc. Also: beta, dev, canary -or nightly- is accepted)
       --browser-path <BROWSER_PATH>
-          Browser path (absolute) for browser version detection (e.g., /usr/bin/google-chrome, "/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome", "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe")
+          Browser path (absolute) for browser version detection (e.g., /usr/bin/google-chrome, "/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome", "C:\Program Files\Google\Chrome\Application\chrome.exe")
       --output <OUTPUT>
           Output type: LOGGER (using INFO, WARN, etc.), JSON (custom JSON notation), or SHELL (Unix-like) [default: LOGGER]
       --proxy <PROXY>

rust/src/chrome.rs

@@ -261,7 +261,8 @@ impl SeleniumManager for ChromeManager {
 
     fn discover_browser_version(&self) -> Option<String> {
         let mut commands;
-        let mut browser_path = self.get_browser_path();
+        let escaped_browser_path = self.get_escaped_browser_path();
+        let mut browser_path = escaped_browser_path.as_str();
         if browser_path.is_empty() {
             match self.detect_browser_path() {
                 Some(path) => {

rust/src/edge.rs

@@ -120,7 +120,8 @@ impl SeleniumManager for EdgeManager {
 
     fn discover_browser_version(&self) -> Option<String> {
         let mut commands;
-        let mut browser_path = self.get_browser_path();
+        let escaped_browser_path = self.get_escaped_browser_path();
+        let mut browser_path = escaped_browser_path.as_str();
         if browser_path.is_empty() {
             match self.detect_browser_path() {
                 Some(path) => {

rust/src/firefox.rs

@@ -120,7 +120,8 @@ impl SeleniumManager for FirefoxManager {
 
     fn discover_browser_version(&self) -> Option<String> {
         let mut commands;
-        let mut browser_path = self.get_browser_path();
+        let escaped_browser_path = self.get_escaped_browser_path();
+        let mut browser_path = escaped_browser_path.as_str();
         if browser_path.is_empty() {
             match self.detect_browser_path() {
                 Some(path) => {

rust/src/lib.rs

@@ -482,6 +482,22 @@ pub trait SeleniumManager {
         self.get_config().browser_path.as_str()
     }
 
+    fn get_escaped_browser_path(&self) -> String {
+        let mut browser_path = self.get_browser_path().to_string();
+        let path = Path::new(&browser_path);
+        if path.exists() && WINDOWS.is(self.get_os()) {
+            browser_path = Path::new(path)
+                .canonicalize()
+                .unwrap()
+                .to_str()
+                .unwrap()
+                .to_string()
+                .replace("\\\\?\\", "")
+                .replace("\\", "\\\\");
+        }
+        browser_path
+    }
+
     fn set_browser_path(&mut self, browser_path: String) {
         if !browser_path.is_empty() {
             let mut config = self.get_config_mut();

rust/src/main.rs

@@ -64,7 +64,7 @@ struct Cli {
 
     /// Browser path (absolute) for browser version detection (e.g., /usr/bin/google-chrome,
     /// "/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
-    /// "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe")
+    /// "C:\Program Files\Google\Chrome\Application\chrome.exe")
     #[clap(long, value_parser)]
     browser_path: Option<String>,
 

rust/src/safari.rs

@@ -76,7 +76,8 @@ impl SeleniumManager for SafariManager {
     }
 
     fn discover_browser_version(&self) -> Option<String> {
-        let mut browser_path = self.get_browser_path();
+        let escaped_browser_path = self.get_escaped_browser_path();
+        let mut browser_path = escaped_browser_path.as_str();
         if browser_path.is_empty() {
             match self.detect_browser_path() {
                 Some(path) => {

rust/src/safaritp.rs

@@ -81,7 +81,8 @@ impl SeleniumManager for SafariTPManager {
     }
 
     fn discover_browser_version(&self) -> Option<String> {
-        let mut browser_path = self.get_browser_path();
+        let escaped_browser_path = self.get_escaped_browser_path();
+        let mut browser_path = escaped_browser_path.as_str();
         if browser_path.is_empty() {
             match self.detect_browser_path() {
                 Some(path) => {

rust/tests/cli_tests.rs

@@ -17,6 +17,7 @@
 
 use assert_cmd::Command;
 use rstest::rstest;
+use std::env::consts::OS;
 use std::str;
 
 #[rstest]
@@ -132,15 +133,22 @@ fn beta_test(#[case] browser: String, #[case] driver_name: String) {
 
 #[rstest]
 #[case(
+    "windows",
     "chrome",
     r#"C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe"#
 )]
-#[case("chrome", "/usr/bin/google-chrome")]
 #[case(
+    "windows",
+    "chrome",
+    r#"C:\Program Files\Google\Chrome\Application\chrome.exe"#
+)]
+#[case("linux", "chrome", "/usr/bin/google-chrome")]
+#[case(
+    "macos",
     "chrome",
     r#"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome"#
 )]
-fn path_test(#[case] browser: String, #[case] browser_path: String) {
+fn path_test(#[case] os: String, #[case] browser: String, #[case] browser_path: String) {
     println!(
         "Path test browser={} -- browser_path={}",
         browser, browser_path
@@ -151,4 +159,11 @@ fn path_test(#[case] browser: String, #[case] browser_path: String) {
         .assert()
         .success()
         .code(0);
+
+    if OS.eq(&os) {
+        let stdout = &cmd.unwrap().stdout;
+        let output = str::from_utf8(stdout).unwrap();
+        println!("output {:?}", output);
+        assert!(!output.contains("WARN"));
+    }
 }