Skip to content

Commit 38f0e36

Browse files
committed
Grid: Better attempt to extract capabilities
Be a little more cautious about extracting capabilities when in Grid.
1 parent a42e31a commit 38f0e36

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

java/server/src/org/openqa/grid/web/servlet/handler/WebDriverRequest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,20 @@ public Map<String, Object> extractDesiredCapability() {
6363
String json = getBody();
6464
try {
6565
JsonObject map = new JsonParser().parse(json).getAsJsonObject();
66-
// Current W3C has required / desired capabilities wrapped in a 'capabilites' object.
66+
System.out.println("map = " + map);
67+
// Current W3C has required / desired capabilities wrapped in a 'capabilities' object.
6768
// This will need to be updated if/when https://github.com/w3c/webdriver/pull/327 gets merged
6869
if (map.has("capabilities")) {
69-
return new JsonToBeanConverter().convert(Map.class, map.getAsJsonObject("capabilities").getAsJsonObject("desiredCapabilities"));
70+
JsonObject outerCapabilities = map.getAsJsonObject("capabilities");
71+
if (outerCapabilities.has("desiredCapabilities")) {
72+
JsonObject desiredCapabilities = outerCapabilities.getAsJsonObject("desiredCapabilities");
73+
System.out.println("desiredCapabilities = " + desiredCapabilities);
74+
return new JsonToBeanConverter().convert(Map.class, desiredCapabilities);
75+
}
7076
}
7177
JsonObject dc = map.get("desiredCapabilities").getAsJsonObject();
78+
System.out.println("dc = " + dc);
7279
return new JsonToBeanConverter().convert(Map.class, dc);
73-
7480
} catch (Exception e) {
7581
throw new GridException("Cannot extract a capabilities from the request: " + json, e);
7682
}

0 commit comments

Comments
 (0)