Skip to content

Commit 44ef2cb

Browse files
Update window commands to use W3C End points
When speaking to a W3C End point we should use the W3C Window endpoints instead of the JSONWP ones.
1 parent 5f96eb0 commit 44ef2cb

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

py/selenium/webdriver/remote/command.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ class Command(object):
5656
SUBMIT_ELEMENT = "submitElement"
5757
UPLOAD_FILE = "uploadFile"
5858
GET_CURRENT_WINDOW_HANDLE = "getCurrentWindowHandle"
59+
W3C_GET_CURRENT_WINDOW_HANDLE = "w3cGetCurrentWindowHandle"
5960
GET_WINDOW_HANDLES = "getWindowHandles"
61+
W3C_GET_WINDOW_HANDLES = "w3cGetWindowHandles"
6062
GET_WINDOW_SIZE = "getWindowSize"
6163
W3C_GET_WINDOW_SIZE = "w3cGetWindowSize"
6264
W3C_GET_WINDOW_POSITION = "w3cGetWindowPosition"

py/selenium/webdriver/remote/remote_connection.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,12 @@ def __init__(self, remote_server_addr, keep_alive=False, resolve_ip=True):
233233
Command.QUIT: ('DELETE', '/session/$sessionId'),
234234
Command.GET_CURRENT_WINDOW_HANDLE:
235235
('GET', '/session/$sessionId/window_handle'),
236+
Command.W3C_GET_CURRENT_WINDOW_HANDLE:
237+
('GET', '/session/$sessionId/window'),
236238
Command.GET_WINDOW_HANDLES:
237239
('GET', '/session/$sessionId/window_handles'),
240+
Command.W3C_GET_WINDOW_HANDLES:
241+
('GET', '/session/$sessionId/window/handles'),
238242
Command.GET: ('POST', '/session/$sessionId/url'),
239243
Command.GO_FORWARD: ('POST', '/session/$sessionId/forward'),
240244
Command.GO_BACK: ('POST', '/session/$sessionId/back'),

py/selenium/webdriver/remote/webdriver.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,10 @@ def current_window_handle(self):
553553
:Usage:
554554
driver.current_window_handle
555555
"""
556-
return self.execute(Command.GET_CURRENT_WINDOW_HANDLE)['value']
556+
if self.w3c:
557+
return self.execute(Command.W3C_GET_CURRENT_WINDOW_HANDLE)['value']
558+
else:
559+
return self.execute(Command.GET_CURRENT_WINDOW_HANDLE)['value']
557560

558561
@property
559562
def window_handles(self):
@@ -563,7 +566,10 @@ def window_handles(self):
563566
:Usage:
564567
driver.window_handles
565568
"""
566-
return self.execute(Command.GET_WINDOW_HANDLES)['value']
569+
if self.w3c:
570+
return self.execute(Command.W3C_GET_WINDOW_HANDLES)['value']
571+
else:
572+
return self.execute(Command.GET_WINDOW_HANDLES)['value']
567573

568574
def maximize_window(self):
569575
"""

0 commit comments

Comments
 (0)