Skip to content

Commit 48ce781

Browse files
committed
Avoid prematurely serializing the Proxy in FirefoxDriver
It'll be correctly converted to a json object and sent across the wire, and the XPI was already half expecting a valid object too.
1 parent aa2d8a8 commit 48ce781

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ private static FirefoxOptions getFirefoxOptions(Capabilities capabilities) {
242242
if (marionette instanceof Boolean) {
243243
options.setLegacy(!(Boolean) marionette);
244244
}
245+
245246
return options;
246247
}
247248

@@ -302,7 +303,7 @@ private static Capabilities dropCapabilities(Capabilities capabilities) {
302303
// Ensure that the proxy is in a state fit to be sent to the extension
303304
Proxy proxy = Proxy.extractFrom(capabilities);
304305
if (proxy != null) {
305-
caps.setCapability(PROXY, new BeanToJsonConverter().convert(proxy));
306+
caps.setCapability(PROXY, proxy);
306307
}
307308

308309
return caps;

0 commit comments

Comments
 (0)