Skip to content

Commit 5036d9d

Browse files
barancevbarancev
committed
Removing PhantomJS ignored test labels
1 parent 6ed28ab commit 5036d9d

31 files changed

+1
-113
lines changed

‎java/client/test/org/openqa/selenium/AlertsTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
3333
import static org.openqa.selenium.testing.Driver.IE;
3434
import static org.openqa.selenium.testing.Driver.MARIONETTE;
35-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3635
import static org.openqa.selenium.testing.Driver.SAFARI;
3736
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
3837
import static org.openqa.selenium.testing.TestUtilities.getFirefoxVersion;
@@ -52,7 +51,6 @@
5251
import java.util.Set;
5352

5453
@Ignore(value = CHROME, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=1500")
55-
@Ignore(PHANTOMJS)
5654
@Ignore(SAFARI)
5755
public class AlertsTest extends JUnit4TestBase {
5856

‎java/client/test/org/openqa/selenium/ClickScrollingTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
3333
import static org.openqa.selenium.testing.Driver.IE;
3434
import static org.openqa.selenium.testing.Driver.MARIONETTE;
35-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3635
import static org.openqa.selenium.testing.Driver.SAFARI;
3736
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
3837

@@ -131,7 +130,6 @@ public void testShouldNotScrollOverflowElementsWhichAreVisible() {
131130

132131
@Test
133132
@Ignore(CHROME)
134-
@Ignore(PHANTOMJS)
135133
@Ignore(value = SAFARI,
136134
reason = "Safari: button1 is scrolled to the bottom edge of the view, " +
137135
"so additonal scrolling is still required for button2")

‎java/client/test/org/openqa/selenium/CookieImplementationTest.java‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import static org.openqa.selenium.testing.Driver.CHROME;
3232
import static org.openqa.selenium.testing.Driver.FIREFOX;
3333
import static org.openqa.selenium.testing.Driver.IE;
34-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3534
import static org.openqa.selenium.testing.Driver.SAFARI;
3635

3736
import org.junit.Before;
@@ -204,7 +203,6 @@ public void testAddCookiesWithDifferentPathsThatAreRelatedToOurs() {
204203
@SwitchToTopAfterTest
205204
@Test
206205
@Ignore(CHROME)
207-
@Ignore(PHANTOMJS)
208206
@Ignore(SAFARI)
209207
public void testGetCookiesInAFrame() {
210208
driver.get(domainHelper.getUrlForFirstValidHostname("/common/animals"));
@@ -378,7 +376,6 @@ public void testRetainsCookieExpiry() {
378376

379377
@Test
380378
@Ignore(IE)
381-
@Ignore(PHANTOMJS)
382379
@Ignore(SAFARI)
383380
public void canHandleSecureCookie() {
384381
driver.get(domainHelper.getSecureUrlForFirstValidHostname("animals"));
@@ -398,7 +395,6 @@ public void canHandleSecureCookie() {
398395

399396
@Test
400397
@Ignore(IE)
401-
@Ignore(PHANTOMJS)
402398
@Ignore(SAFARI)
403399
public void testRetainsCookieSecure() {
404400
driver.get(domainHelper.getSecureUrlForFirstValidHostname("animals"));
@@ -486,7 +482,6 @@ public void testDeleteNotExistedCookie() {
486482
@Ignore(CHROME)
487483
@Ignore(FIREFOX)
488484
@Ignore(IE)
489-
@Ignore(PHANTOMJS)
490485
@Ignore(SAFARI)
491486
public void testShouldDeleteOneOfTheCookiesWithTheSameName() {
492487
driver.get(domainHelper.getUrlForFirstValidHostname("/common/animals"));

‎java/client/test/org/openqa/selenium/ExecutingAsyncJavascriptTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
3333
import static org.openqa.selenium.testing.Driver.IE;
3434
import static org.openqa.selenium.testing.Driver.MARIONETTE;
35-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3635
import static org.openqa.selenium.testing.Driver.SAFARI;
3736
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
3837

@@ -49,7 +48,6 @@
4948
import java.util.List;
5049
import java.util.concurrent.TimeUnit;
5150

52-
@Ignore(PHANTOMJS)
5351
public class ExecutingAsyncJavascriptTest extends JUnit4TestBase {
5452

5553
private JavascriptExecutor executor;

‎java/client/test/org/openqa/selenium/ExecutingJavascriptTest.java‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
3838
import static org.openqa.selenium.testing.Driver.IE;
3939
import static org.openqa.selenium.testing.Driver.MARIONETTE;
40-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
4140
import static org.openqa.selenium.testing.Driver.SAFARI;
4241
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
4342

@@ -276,7 +275,6 @@ public void testShouldThrowAnExceptionWhenTheJavascriptIsBad() {
276275
@Test
277276
@Ignore(CHROME)
278277
@Ignore(IE)
279-
@Ignore(PHANTOMJS)
280278
@Ignore(SAFARI)
281279
@Ignore(MARIONETTE)
282280
@NotYetImplemented(HTMLUNIT)
@@ -525,7 +523,6 @@ public void testShouldThrowAnExceptionWhenArgumentsWithStaleElementPassed() {
525523
@Test
526524
@Ignore(CHROME)
527525
@Ignore(IE)
528-
@Ignore(PHANTOMJS)
529526
@Ignore(SAFARI)
530527
@Ignore(MARIONETTE)
531528
public void testShouldBeAbleToReturnADateObject() {
@@ -543,7 +540,6 @@ public void testShouldBeAbleToReturnADateObject() {
543540
@Test(timeout = 10000)
544541
@Ignore(CHROME)
545542
@Ignore(IE)
546-
@Ignore(PHANTOMJS)
547543
@Ignore(SAFARI)
548544
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/904")
549545
public void shouldReturnDocumentElementIfDocumentIsReturned() {
@@ -557,7 +553,6 @@ public void shouldReturnDocumentElementIfDocumentIsReturned() {
557553

558554
@Test(timeout = 10000)
559555
@Ignore(value = IE, reason = "returns WebElement")
560-
@Ignore(PHANTOMJS)
561556
@Ignore(SAFARI)
562557
@Ignore(HTMLUNIT)
563558
public void shouldHandleObjectThatThatHaveToJSONMethod() {
@@ -571,7 +566,6 @@ public void shouldHandleObjectThatThatHaveToJSONMethod() {
571566
@Test(timeout = 10000)
572567
@Ignore(CHROME)
573568
@Ignore(value = IE, issue = "540")
574-
@Ignore(PHANTOMJS)
575569
@Ignore(SAFARI)
576570
@Ignore(value = FIREFOX, issue = "540")
577571
@Ignore(HTMLUNIT)

‎java/client/test/org/openqa/selenium/FormHandlingTest.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import static org.openqa.selenium.support.ui.ExpectedConditions.titleIs;
3030
import static org.openqa.selenium.testing.Driver.IE;
3131
import static org.openqa.selenium.testing.Driver.MARIONETTE;
32-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3332
import static org.openqa.selenium.testing.Driver.SAFARI;
3433
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
3534
import static org.openqa.selenium.testing.TestUtilities.isIe6;
@@ -91,7 +90,6 @@ public void testShouldSubmitAFormWhenAnyElementWithinThatFormIsSubmitted() {
9190
}
9291

9392
@Test
94-
@Ignore(PHANTOMJS)
9593
@Ignore(SAFARI)
9694
@NotYetImplemented(
9795
value = MARIONETTE, reason = "Delegates to JS and so the wrong exception is returned")
@@ -259,7 +257,6 @@ public void testEmptyTextBoxesShouldReturnAnEmptyStringNotNull() {
259257
}
260258

261259
@Test
262-
@Ignore(PHANTOMJS)
263260
@Ignore(SAFARI)
264261
public void handleFormWithJavascriptAction() {
265262
String url = appServer.whereIs("form_handling_js_submit.html");

‎java/client/test/org/openqa/selenium/FrameSwitchingTest.java‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
3535
import static org.openqa.selenium.testing.Driver.IE;
3636
import static org.openqa.selenium.testing.Driver.MARIONETTE;
37-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3837
import static org.openqa.selenium.testing.Driver.SAFARI;
3938
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
4039

@@ -238,7 +237,6 @@ public void testShouldThrowAnExceptionWhenAFrameCannotBeFoundByIndex() {
238237

239238
@Test
240239
@Ignore(IE)
241-
@Ignore(PHANTOMJS)
242240
@Ignore(SAFARI)
243241
public void testShouldBeAbleToSwitchToParentFrame() {
244242
driver.get(pages.framesetPage);
@@ -249,7 +247,6 @@ public void testShouldBeAbleToSwitchToParentFrame() {
249247

250248
@Test
251249
@Ignore(IE)
252-
@Ignore(PHANTOMJS)
253250
@Ignore(SAFARI)
254251
public void testShouldBeAbleToSwitchToParentFrameFromASecondLevelFrame() {
255252
driver.get(pages.framesetPage);
@@ -261,7 +258,6 @@ public void testShouldBeAbleToSwitchToParentFrameFromASecondLevelFrame() {
261258

262259
@Test
263260
@Ignore(IE)
264-
@Ignore(PHANTOMJS)
265261
@Ignore(SAFARI)
266262
public void testSwitchingToParentFrameFromDefaultContextIsNoOp() {
267263
driver.get(pages.xhtmlTestPage);
@@ -271,7 +267,6 @@ public void testSwitchingToParentFrameFromDefaultContextIsNoOp() {
271267

272268
@Test
273269
@Ignore(IE)
274-
@Ignore(PHANTOMJS)
275270
@Ignore(SAFARI)
276271
public void testShouldBeAbleToSwitchToParentFromAnIframe() {
277272
driver.get(pages.iframePage);
@@ -393,7 +388,6 @@ public void testShouldBeAbleToFindElementsInIframesByXPath() {
393388

394389
@Test
395390
@Ignore(IE)
396-
@Ignore(PHANTOMJS)
397391
@Ignore(SAFARI)
398392
public void testGetCurrentUrlReturnsTopLevelBrowsingContextUrl() {
399393
driver.get(pages.framesetPage);
@@ -405,7 +399,6 @@ public void testGetCurrentUrlReturnsTopLevelBrowsingContextUrl() {
405399

406400
@Test
407401
@Ignore(IE)
408-
@Ignore(PHANTOMJS)
409402
@Ignore(SAFARI)
410403
public void testGetCurrentUrlReturnsTopLevelBrowsingContextUrlForIframes() {
411404
driver.get(pages.iframePage);
@@ -416,7 +409,6 @@ public void testGetCurrentUrlReturnsTopLevelBrowsingContextUrlForIframes() {
416409
}
417410

418411
@Test
419-
@Ignore(PHANTOMJS)
420412
public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUs() {
421413
driver.get(appServer.whereIs("frame_switching_tests/deletingFrame.html"));
422414

@@ -438,7 +430,6 @@ public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUs() {
438430
}
439431

440432
@Test
441-
@Ignore(PHANTOMJS)
442433
public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithFrameIndex() {
443434
driver.get(appServer.whereIs("frame_switching_tests/deletingFrame.html"));
444435
int iframe = 0;
@@ -457,7 +448,6 @@ public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithFr
457448
}
458449

459450
@Test
460-
@Ignore(PHANTOMJS)
461451
public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithWebelement() {
462452
driver.get(appServer.whereIs("frame_switching_tests/deletingFrame.html"));
463453
WebElement iframe = driver.findElement(By.id("iframe1"));
@@ -480,7 +470,6 @@ public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithWe
480470
@Ignore(CHROME)
481471
@Ignore(IE)
482472
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/614")
483-
@Ignore(PHANTOMJS)
484473
@Ignore(SAFARI)
485474
@NotYetImplemented(HTMLUNIT)
486475
public void testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs() {

‎java/client/test/org/openqa/selenium/ImplicitWaitTest.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import static org.junit.Assert.assertTrue;
2626
import static org.openqa.selenium.testing.Driver.IE;
2727
import static org.openqa.selenium.testing.Driver.MARIONETTE;
28-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
2928
import static org.openqa.selenium.testing.Driver.SAFARI;
3029
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
3130

@@ -128,7 +127,6 @@ public void testShouldReturnAfterFirstAttemptToFindManyAfterDisablingImplicitWai
128127
@Test
129128
@Ignore(IE)
130129
@Ignore(MARIONETTE)
131-
@Ignore(PHANTOMJS)
132130
@Ignore(SAFARI)
133131
public void testShouldImplicitlyWaitForAnElementToBeVisibleBeforeInteracting() {
134132
driver.get(pages.dynamicPage);
@@ -144,7 +142,6 @@ public void testShouldImplicitlyWaitForAnElementToBeVisibleBeforeInteracting() {
144142

145143
@Test
146144
@Ignore(IE)
147-
@Ignore(PHANTOMJS)
148145
@Ignore(SAFARI)
149146
public void testShouldRetainImplicitlyWaitFromTheReturnedWebDriverOfFrameSwitchTo() {
150147
driver.manage().timeouts().implicitlyWait(1, SECONDS);

‎java/client/test/org/openqa/selenium/PageLoadingTest.java‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
4242
import static org.openqa.selenium.testing.Driver.IE;
4343
import static org.openqa.selenium.testing.Driver.MARIONETTE;
44-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
4544
import static org.openqa.selenium.testing.Driver.SAFARI;
4645
import static org.openqa.selenium.testing.TestUtilities.catchThrowable;
4746
import static org.openqa.selenium.testing.TestUtilities.getEffectivePlatform;
@@ -78,7 +77,6 @@ private void initLocalDriver(String strategy) {
7877
@Test
7978
@Ignore(CHROME)
8079
@Ignore(SAFARI)
81-
@Ignore(PHANTOMJS)
8280
@NeedsLocalEnvironment
8381
public void testNoneStrategyShouldNotWaitForPageToLoad() {
8482
initLocalDriver("none");
@@ -97,7 +95,6 @@ public void testNoneStrategyShouldNotWaitForPageToLoad() {
9795

9896
@Test
9997
@Ignore(SAFARI)
100-
@Ignore(PHANTOMJS)
10198
@NeedsLocalEnvironment
10299
public void testNoneStrategyShouldNotWaitForPageToRefresh() {
103100
initLocalDriver("none");
@@ -122,7 +119,6 @@ public void testNoneStrategyShouldNotWaitForPageToRefresh() {
122119
@Ignore(IE)
123120
@Ignore(CHROME)
124121
@Ignore(SAFARI)
125-
@Ignore(PHANTOMJS)
126122
@NeedsLocalEnvironment
127123
public void testEagerStrategyShouldNotWaitForResources() {
128124
initLocalDriver("eager");
@@ -146,7 +142,6 @@ public void testEagerStrategyShouldNotWaitForResources() {
146142
@Ignore(IE)
147143
@Ignore(CHROME)
148144
@Ignore(SAFARI)
149-
@Ignore(PHANTOMJS)
150145
@NeedsLocalEnvironment
151146
public void testEagerStrategyShouldNotWaitForResourcesOnRefresh() {
152147
initLocalDriver("eager");
@@ -224,7 +219,6 @@ public void testShouldReturnWhenGettingAUrlThatDoesNotResolve() {
224219
@Test
225220
@Ignore(IE)
226221
@Ignore(SAFARI)
227-
@Ignore(PHANTOMJS)
228222
@NeedsFreshDriver
229223
public void testShouldThrowIfUrlIsMalformed() {
230224
assumeFalse("Fails in Sauce Cloud", SauceDriver.shouldUseSauce());
@@ -235,7 +229,6 @@ public void testShouldThrowIfUrlIsMalformed() {
235229
@Test
236230
@Ignore(IE)
237231
@Ignore(SAFARI)
238-
@Ignore(PHANTOMJS)
239232
@NeedsFreshDriver
240233
public void testShouldThrowIfUrlIsMalformedInPortPart() {
241234
assumeFalse("Fails in Sauce Cloud", SauceDriver.shouldUseSauce());
@@ -341,7 +334,6 @@ public void testShouldBeAbleToNavigateForwardsInTheBrowserHistory() {
341334

342335
@Test
343336
@Ignore(IE)
344-
@Ignore(PHANTOMJS)
345337
@Ignore(value = SAFARI, reason = "does not support insecure SSL")
346338
public void testShouldBeAbleToAccessPagesWithAnInsecureSslCertificate() {
347339
// TODO(user): Set the SSL capability to true.
@@ -385,7 +377,6 @@ public void testShouldNotHangIfDocumentOpenCallIsNeverFollowedByDocumentCloseCal
385377
// if @NoDriverAfterTest can be removed from some other tests in this class.
386378
@NoDriverAfterTest
387379
@Test
388-
@Ignore(PHANTOMJS)
389380
@Ignore(FIREFOX)
390381
@Ignore(value = SAFARI, reason = "issue 687, comment 41")
391382
@NeedsLocalEnvironment
@@ -396,7 +387,6 @@ public void testPageLoadTimeoutCanBeChanged() {
396387

397388
@NoDriverAfterTest
398389
@Test
399-
@Ignore(PHANTOMJS)
400390
@Ignore(FIREFOX)
401391
@Ignore(value = SAFARI, reason = "issue 687, comment 41")
402392
@NeedsLocalEnvironment

‎java/client/test/org/openqa/selenium/PositionAndSizeTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
3232
import static org.openqa.selenium.testing.Driver.IE;
3333
import static org.openqa.selenium.testing.Driver.MARIONETTE;
34-
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
3534
import static org.openqa.selenium.testing.Driver.SAFARI;
3635

3736
import org.junit.Test;
@@ -172,7 +171,6 @@ public void testShouldCorrectlyIdentifyThatAnElementHasWidthAndHeight() {
172171
@Ignore(IE)
173172
@Ignore(value = CHROME, reason = "WebKit bug 28804")
174173
@Ignore(SAFARI)
175-
@Ignore(PHANTOMJS)
176174
@Ignore(MARIONETTE)
177175
public void testShouldHandleNonIntegerPositionAndSize() {
178176
driver.get(pages.rectanglesPage);

0 commit comments

Comments
 (0)