Buck version bump

This brings us up to date with Facebook's Buck release,
with the following additions:

* Simple Console reports "STILL BUILDING" if a rule
  takes too long (required for Travis)
* Empty javadoc jars are now valid (required for maven)
* We encode a build stamp into each java build

The build stamp is a dependency of the core Java
WebDriver interfaces (added in the manifest of
`//java/client/src/org/openqa/selenium:core`). Since
this rule is built _every time_ we invoke Buck, we
expect to see more rebuilds. In the general case, ABI
checks will mean only java_binary artifacts are rebuilt
so build times should not be impacted.

Author: shs96c

.buckhash

@@ -1 +1 @@
-c7c2e785df8e7d0cf14f3afd59afbd39
+0524bd3cf64bf94800a8ca48927ecd16

.buckversion

@@ -1 +1 @@
-65874cbc58fab1746c2e7d15ea7c2f545fb0df38
+7e370f5f00f23d09d1607fdae79c8bd003462fdc

java/client/src/org/openqa/selenium/BUCK

@@ -1,5 +1,10 @@
 include_defs('//SELENIUM_VERSION')
 
+build_stamp(name = 'build-stamp',
+  kind = 'manifest',
+  source_control_system = 'git',
+)
+
 java_library(name = 'selenium',
   exported_deps = [
     ':beta',
@@ -76,8 +81,8 @@ java_library(name = 'core',
 
 genrule(name = 'manifest',
   out = 'manifest.mf',
-  bash = 'printf "\nName: Build-Info\nSelenium-Version: {}\n" > $OUT'.format(SE_VERSION),
-  cmd_exe = "(echo.\necho Name: Build-Info\necho Selenium-Version: {}\n) > %OUT%".format(SE_VERSION),
+  bash = 'cp $(location :build-stamp) $OUT && printf "Selenium-Version: {}\n\n" >> $OUT'.format(SE_VERSION),
+  cmd_exe = "copy $(location :build-stamp) %OUT% && (echo Selenium-Version: {}\n\n) >> %OUT%".format(SE_VERSION),
 )
 
 java_library(name = 'beta',

javascript/JAVASCRIPT_DEFS

@@ -1,7 +1,7 @@
-orig_js_fragment = js_fragment
+orig_closure_fragment = closure_fragment
 
-def js_fragment(name, **kwargs):
-    orig_js_fragment(name, **kwargs)
+def closure_fragment(name, **kwargs):
+    orig_closure_fragment(name, **kwargs)
 
     # Android
     defs = kwargs.get('defines', [])
@@ -11,7 +11,7 @@ def js_fragment(name, **kwargs):
     args = kwargs.copy();
     args['defines'] = defs
     fragment_name = name + '-android'
-    orig_js_fragment(fragment_name, **args)
+    orig_closure_fragment(fragment_name, **args)
 
     # Chrome
     defs = kwargs.get('defines', [])
@@ -22,7 +22,7 @@ def js_fragment(name, **kwargs):
     args = kwargs.copy();
     args['defines'] = defs
     fragment_name = name + '-chrome'
-    orig_js_fragment(fragment_name, **args)
+    orig_closure_fragment(fragment_name, **args)
 
     # Edge and IE
     defs = kwargs.get('defines', [])
@@ -32,7 +32,7 @@ def js_fragment(name, **kwargs):
     args = kwargs.copy();
     args['defines'] = defs
     fragment_name = name + '-ie'
-    orig_js_fragment(fragment_name, **args)
+    orig_closure_fragment(fragment_name, **args)
 
     # iOS
     defs = kwargs.get('defines', [])
@@ -44,7 +44,7 @@ def js_fragment(name, **kwargs):
     args = kwargs.copy();
     args['defines'] = defs
     fragment_name = name + '-ios'
-    orig_js_fragment(fragment_name, **args)
+    orig_closure_fragment(fragment_name, **args)
 
 
     # Firefox
@@ -56,4 +56,4 @@ def js_fragment(name, **kwargs):
     args = kwargs.copy();
     args['defines'] = defs
     fragment_name = name + '-firefox'
-    orig_js_fragment(fragment_name, **args)
+    orig_closure_fragment(fragment_name, **args)

javascript/atoms/BUCK

@@ -1,4 +1,4 @@
-js_library(name = 'action',
+closure_library(name = 'action',
   srcs = [
     'action.js',
   ],
@@ -15,7 +15,7 @@ js_library(name = 'action',
 )
 
 
-js_library(name = 'bot',
+closure_library(name = 'bot',
   srcs = [
     'bot.js',
   ],
@@ -25,7 +25,7 @@ js_library(name = 'bot',
 )
 
 
-js_library(name = 'color',
+closure_library(name = 'color',
   srcs = [
     'color.js',
   ],
@@ -35,7 +35,7 @@ js_library(name = 'color',
 )
 
 
-js_library(name = 'devices',
+closure_library(name = 'devices',
   srcs = [
     'device.js',
     'keyboard.js',
@@ -55,7 +55,7 @@ js_library(name = 'devices',
 )
 
 
-js_library(name = 'domcore',
+closure_library(name = 'domcore',
   srcs = [
     "domcore.js",
   ],
@@ -70,7 +70,7 @@ js_library(name = 'domcore',
 )
 
 
-js_library(name = 'dom',
+closure_library(name = 'dom',
   srcs = [
     "dom.js",
   ],
@@ -88,7 +88,7 @@ js_library(name = 'dom',
 )
 
 
-js_library(name = 'errors',
+closure_library(name = 'errors',
   srcs = [
     'error.js',
     'response.js',
@@ -99,7 +99,7 @@ js_library(name = 'errors',
 )
 
 
-js_library(name = 'events',
+closure_library(name = 'events',
   srcs = [
     'events.js',
   ],
@@ -116,7 +116,7 @@ js_library(name = 'events',
 )
 
 
-js_library(name = 'html5',
+closure_library(name = 'html5',
   srcs = glob(['html5/*.js']),
   deps = [
     ':bot',
@@ -130,7 +130,7 @@ js_library(name = 'html5',
 )
 
 
-js_library(name = 'inject',
+closure_library(name = 'inject',
   srcs = [
     'inject.js',
     'response.js',
@@ -147,7 +147,7 @@ js_library(name = 'inject',
 )
 
 
-js_library(name = 'json',
+closure_library(name = 'json',
   srcs = [
     'json.js',
     'userAgent.js'
@@ -161,7 +161,7 @@ js_library(name = 'json',
 )
 
 
-js_library(name = 'locators',
+closure_library(name = 'locators',
   srcs = glob(['locators/*.js'], excludes=['locators/xpath.js']),
   deps = [
     ':dom',
@@ -175,7 +175,7 @@ js_library(name = 'locators',
 )
 
 
-js_library(name = 'useragent',
+closure_library(name = 'useragent',
   srcs = [
     'userAgent.js',
   ],
@@ -188,7 +188,7 @@ js_library(name = 'useragent',
 )
 
 
-js_library(name = 'window',
+closure_library(name = 'window',
   srcs = [
     'frame.js',
     'window.js',
@@ -207,7 +207,7 @@ js_library(name = 'window',
 )
 
 
-js_library(name = 'xpath',
+closure_library(name = 'xpath',
   srcs = [
     'locators/xpath.js',
   ],

javascript/atoms/fragments/BUCK

@@ -1,14 +1,14 @@
 include_defs('//javascript/JAVASCRIPT_DEFS')
 
-js_fragment(name = 'clear',
+closure_fragment(name = 'clear',
   function = 'bot.action.clear',
   module = 'bot.action',
   deps = [
     '//javascript/atoms:action',
   ],
 )
 
-js_fragment(name = 'execute_script',
+closure_fragment(name = 'execute_script',
   function = 'bot.inject.executeScript',
   module = 'bot.inject',
   deps = [
@@ -19,7 +19,7 @@ js_fragment(name = 'execute_script',
   ],
 )
 
-js_fragment(name = 'is-displayed',
+closure_fragment(name = 'is-displayed',
   function = 'bot.dom.isShown',
   module = 'bot.dom',
   deps = [

javascript/chrome-driver/BUCK

@@ -1,4 +1,4 @@
-js_library(name = 'lib',
+closure_library(name = 'lib',
   srcs = glob(['*.js']),
   deps = [
     '//javascript/atoms:dom',
@@ -7,35 +7,35 @@ js_library(name = 'lib',
   ],
 )
 
-js_fragment(name = 'get_location_in_view',
+closure_fragment(name = 'get_location_in_view',
   module = 'webdriver.chrome',
   function = 'webdriver.chrome.getLocationInView',
   deps = [ ':lib' ])
 
-js_fragment(name = 'get_first_client_rect',
+closure_fragment(name = 'get_first_client_rect',
   module = 'webdriver.chrome',
   function = 'webdriver.chrome.getFirstClientRect',
   deps = [ ':lib' ])
 
-js_fragment(name = 'is_element_clickable',
+closure_fragment(name = 'is_element_clickable',
   module = 'webdriver.chrome',
   function = 'webdriver.chrome.isElementClickable',
   deps = [ ':lib' ])
 
-js_fragment(name = 'get_page_zoom',
+closure_fragment(name = 'get_page_zoom',
   module = 'webdriver.chrome',
   function = 'webdriver.chrome.getPageZoom',
   deps = [ ':lib' ])
 
-js_fragment(name = 'is_element_displayed',
+closure_fragment(name = 'is_element_displayed',
   module = 'webdriver.chrome',
   function = 'webdriver.chrome.isElementDisplayed',
   deps = [
     ':lib',
     '//javascript/atoms/fragments:is-displayed',
     ])
 
-js_fragment(name = 'find_element',
+closure_fragment(name = 'find_element',
   module = 'webdriver.chrome',
   function = 'webdriver.chrome.findElement',
   deps = [ ':lib' ])