Skip to content

Commit 549996d

Browse files
committed
Don't construct a new FirefoxBinary() if one is already provided.
The FirefoxBinary() constructor can throw, so avoid calling it in this case, where the result is going to be discarded anyway.
1 parent e58ad4a commit 549996d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

java/client/src/org/openqa/selenium/firefox/FirefoxOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public FirefoxOptions setBinary(String path) {
194194
* useful when actually starting firefox.
195195
*/
196196
public FirefoxBinary getBinary() {
197-
return getBinaryOrNull().orElse(new FirefoxBinary());
197+
return getBinaryOrNull().orElseGet(() -> new FirefoxBinary());
198198
}
199199

200200
public Optional<FirefoxBinary> getBinaryOrNull() {

0 commit comments

Comments
 (0)