Allow IE driver to work with transparent file upload elements.

Many modern JavaScript widget frameworks hide <input type="file"> elements
so as to make their UIs "prettier." The IE driver would see these elements
as not visible, and thus not interactible. This commit allows users to use
sendKeys to upload files when this type of file upload element exists,
bringing the driver in line with what is allowed by the Firefox driver.

Author: jimevans

cpp/iedriver/CommandHandlers/SendKeysCommandHandler.h

@@ -80,20 +80,6 @@ class SendKeysCommandHandler : public IECommandHandler {
       status_code = this->GetElement(executor, element_id, &element_wrapper);
 
       if (status_code == WD_SUCCESS) {
-        bool displayed;
-        status_code = element_wrapper->IsDisplayed(true, &displayed);
-        if (status_code != WD_SUCCESS || !displayed) {
-          response->SetErrorResponse(EELEMENTNOTDISPLAYED,
-                                     "Element is not displayed");
-          return;
-        }
-
-        if (!element_wrapper->IsEnabled()) {
-          response->SetErrorResponse(EELEMENTNOTENABLED,
-                                     "Element is not enabled");
-          return;
-        }
-
         CComPtr<IHTMLElement> element(element_wrapper->element());
 
         LocationInfo location = {};
@@ -147,6 +133,20 @@ class SendKeysCommandHandler : public IECommandHandler {
           return;
         }
 
+        bool displayed;
+        status_code = element_wrapper->IsDisplayed(true, &displayed);
+        if (status_code != WD_SUCCESS || !displayed) {
+          response->SetErrorResponse(EELEMENTNOTDISPLAYED,
+                                     "Element is not displayed");
+          return;
+        }
+
+        if (!element_wrapper->IsEnabled()) {
+          response->SetErrorResponse(EELEMENTNOTENABLED,
+                                     "Element is not enabled");
+          return;
+        }
+
         if (!this->VerifyPageHasFocus(top_level_window_handle, window_handle)) {
           LOG(WARN) << "HTML rendering pane does not have the focus. Keystrokes may go to an unexpected UI element.";
         }

cpp/iedriver/Generated/atoms.h

@@ -9,6 +9,16 @@ available via the project downloads page. Changes in "revision" field indicate
 private releases checked into the prebuilts directory of the source tree, but
 not made generally available on the downloads page.
 
+v2.45.0.6
+=========
+ * Updates to JavaScript automation atoms.
+ * Allow IE driver to work with transparent file upload elements. Many modern
+   JavaScript widget frameworks hide <input type="file"> elements so as to
+   make their UIs "prettier." The IE driver would see these elements as not
+   visible, and thus not interactible. This commit allows users to use sendKeys
+   to upload files when this type of file upload element exists, bringing the
+   driver in line with what is allowed by the Firefox driver.
+
 v2.45.0.5
 =========
  * Changed to allow interaction with elements where opacity = 0. The

cpp/iedriverserver/CHANGELOG

@@ -46,7 +46,7 @@ public void ShouldAllowFileUploading()
         [Test]
         [Category("Javascript")]
         [IgnoreBrowser(Browser.WindowsPhone, "Does not yet support file uploads")]
-        [IgnoreBrowser(Browser.IE, "Transparent file upload element not yet handled")]
+        //[IgnoreBrowser(Browser.IE, "Transparent file upload element not yet handled")]
         public void ShouldAllowFileUploadingUsingTransparentUploadElement()
         {
             driver.Url = transparentUploadPage;