File tree Expand file tree Collapse file tree 1 file changed +7
-4
lines changed
javascript/firefox-driver/js Expand file tree Collapse file tree 1 file changed +7
-4
lines changed Original file line number Diff line number Diff line change @@ -204,10 +204,13 @@ FirefoxDriver.prototype.close = function(respond) {
204
204
* @see https://code.google.com/p/selenium/issues/detail?id=8390
205
205
*/
206
206
function cloneInto ( originalObject , targetScope ) {
207
- // TODO: this check for FF29 and be removed when we drop support for
208
- // Firefox 24 ESR (when Firefox 38 ESR is released). Hopefully Mozilla's
209
- // Marionette will replace this entire thing by then (doubtful).
210
- if ( bot . userAgent . isProductVersion ( 29 ) ) {
207
+ // While cloneInto was introduced with Gecko 29 and only became required in
208
+ // Gecko 35, we only use it for 33+ as cloneInto fails up to Gecko 32 when
209
+ // DOM elements are included in the cloned object.
210
+ // TODO: this check may be removed when we drop support for Gecko 32 (when
211
+ // Firefox 45 ESR is released). Hopefully Mozilla's Marionette will replace
212
+ // this entire thing by then.
213
+ if ( bot . userAgent . isProductVersion ( 33 ) ) {
211
214
return Components . utils . cloneInto ( originalObject , targetScope , {
212
215
wrapReflectors :true
213
216
} ) ;
You can’t perform that action at this time.
0 commit comments