Skip to content

Commit 64c7ffc

Browse files
committed
Fix resource leak in HubStatusServlet
1 parent ab77a9e commit 64c7ffc

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

java/server/src/org/openqa/grid/web/servlet/HubStatusServlet.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
package org.openqa.grid.web.servlet;
2020

21+
import com.google.common.io.CharStreams;
2122
import com.google.gson.Gson;
2223
import com.google.gson.JsonElement;
2324
import com.google.gson.JsonObject;
@@ -147,17 +148,15 @@ private JsonObject getSlotCounts() {
147148
}
148149

149150
private JsonObject getRequestJSON(HttpServletRequest request) throws IOException {
150-
JsonObject requestJSON = null;
151-
BufferedReader rd = new BufferedReader(new InputStreamReader(request.getInputStream()));
152-
StringBuilder s = new StringBuilder();
153-
String line;
154-
while ((line = rd.readLine()) != null) {
155-
s.append(line);
156-
}
157-
rd.close();
158-
String json = s.toString();
159-
if (!"".equals(json)) {
160-
requestJSON = new JsonParser().parse(json).getAsJsonObject();
151+
JsonObject requestJSON = new JsonObject();
152+
153+
try (BufferedReader rd = new BufferedReader(new InputStreamReader(request.getInputStream()))) {
154+
StringBuilder s = new StringBuilder();
155+
CharStreams.copy(rd, s);
156+
String json = s.toString();
157+
if (!"".equals(json)) {
158+
requestJSON = new JsonParser().parse(json).getAsJsonObject();
159+
}
161160
}
162161
return requestJSON;
163162
}

0 commit comments

Comments
 (0)