Skip to content

Commit 6e0cb6c

Browse files
committed
Deflake AlertsTest and FrameSwitchingTest.
1 parent 170819b commit 6e0cb6c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

java/client/test/org/openqa/selenium/AlertsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ public void testPromptShouldHaveNullValueIfDismissed() {
314314
@JavascriptEnabled
315315
@Test
316316
public void testHandlesTwoAlertsFromOneInteraction() {
317-
driver.findElement(By.id("double-prompt")).click();
317+
wait.until(presenceOfElementLocated(By.id("double-prompt"))).click();
318318

319319
Alert alert1 = wait.until(alertIsPresent());
320320
alert1.sendKeys("brie");

java/client/test/org/openqa/selenium/FrameSwitchingTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,8 @@ public void testShouldNotSwitchMagicallyToTheTopWindow() {
484484

485485
for (int i = 0; i < 20; i++) {
486486
try {
487-
WebElement input = driver.findElement(By.id("inputText"));
488-
WebElement submit = driver.findElement(By.id("submitButton"));
487+
WebElement input = waitFor(elementToExist(driver, "inputText"));
488+
WebElement submit = waitFor(elementToExist(driver, "submitButton"));
489489
input.clear();
490490
input.sendKeys("rand" + new Random().nextInt());
491491
submit.click();
@@ -516,4 +516,4 @@ private void assertFrameNotPresent(WebDriver driver, String locator) {
516516
fail("Frame did not disappear");
517517
}
518518

519-
}
519+
}

0 commit comments

Comments
 (0)