Click after move with offset should use last mouse position

Author: barancev

java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java

@@ -45,6 +45,7 @@
 import org.openqa.selenium.JavascriptExecutor;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.Platform;
+import org.openqa.selenium.Point;
 import org.openqa.selenium.WaitingConditions;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
@@ -218,6 +219,36 @@ public void testCanClickOnLinksWithAnOffset() {
     wait.until(titleIs("XHTML Test Page"));
   }
 
+  @Ignore(
+      value = {HTMLUNIT, IPHONE},
+      reason = "HtmlUnit: Advanced mouse actions only implemented in rendered browsers")
+  @Test
+  public void testClickAfterMoveToAnElementWithAnOffsetShouldUseLastMousePosition() {
+    assumeFalse(isFirefox(driver) && isNativeEventsEnabled(driver));
+
+    driver.get(pages.clickEventPage);
+
+    WebElement element = driver.findElement(By.id("eventish"));
+    Point location = element.getLocation();
+
+    new Actions(driver)
+        .moveToElement(element, 10, 20)
+        .click()
+        .perform();
+
+    int x = Integer.parseInt(driver.findElement(By.id("pageX")).getText());
+    int y = Integer.parseInt(driver.findElement(By.id("pageY")).getText());
+
+    assertTrue(fuzzyPositionMatching(location.getX() + 10, location.getY() + 20, x, y));
+  }
+
+  private boolean fuzzyPositionMatching(int expectedX, int expectedY, int actualX, int actualY) {
+    // Everything within 5 pixels range is OK
+    final int ALLOWED_DEVIATION = 5;
+    return Math.abs(expectedX - actualX) < ALLOWED_DEVIATION &&
+           Math.abs(expectedY - actualY) < ALLOWED_DEVIATION;
+  }
+
   /**
    * This test demonstrates the following problem: When the representation of
    * the mouse in the driver keeps the wrong state, mouse movement will end

javascript/firefox-driver/js/syntheticMouse.js

@@ -182,7 +182,7 @@ SyntheticMouse.prototype.click = function(target) {
     keyboardState.setPressed(bot.Device.Modifier.META, this.modifierKeys.isMetaPressed());
   }
 
-  bot.action.click(element, undefined /* coords */, new bot.Mouse(null, keyboardState));
+  bot.action.click(element, this.lastMousePosition, new bot.Mouse(null, keyboardState));
 
   this.lastElement = element;
 
@@ -201,7 +201,7 @@ SyntheticMouse.prototype.contextClick = function(target) {
   }
 
   fxdriver.logging.info('About to do a bot.action.rightClick on ' + element);
-  bot.action.rightClick(element, undefined /* coords */);
+  bot.action.rightClick(element, this.lastMousePosition);
 
   this.lastElement = element;
 
@@ -218,7 +218,7 @@ SyntheticMouse.prototype.doubleClick = function(target) {
   }
 
   fxdriver.logging.info('About to do a bot.action.doubleClick on ' + element);
-  bot.action.doubleClick(element, undefined /* coords */);
+  bot.action.doubleClick(element, this.lastMousePosition);
 
   this.lastElement = element;