Skip to content

Commit 87730e4

Browse files
committed
HtmlUnit: unignoring several tests that can work with JS off
1 parent 5c278d6 commit 87730e4

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

java/client/test/org/openqa/selenium/AtomsInjectionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
package org.openqa.selenium;
1919

2020
import org.junit.Test;
21-
import org.openqa.selenium.testing.Ignore;
2221
import org.openqa.selenium.testing.JUnit4TestBase;
2322
import org.openqa.selenium.testing.JavascriptEnabled;
23+
import org.openqa.selenium.testing.NotYetImplemented;
2424

2525
import static org.junit.Assert.assertEquals;
2626
import static org.openqa.selenium.testing.Ignore.Driver.MARIONETTE;
@@ -30,7 +30,7 @@ public class AtomsInjectionTest extends JUnit4TestBase {
3030
/** http://code.google.com/p/selenium/issues/detail?id=1333 */
3131
@JavascriptEnabled
3232
@Test
33-
@Ignore({MARIONETTE})
33+
@NotYetImplemented({MARIONETTE})
3434
public void testInjectingAtomShouldNotTrampleOnUnderscoreGlobal() {
3535
driver.get(pages.underscorePage);
3636
driver.findElement(By.tagName("body"));

java/client/test/org/openqa/selenium/ChildrenFindingTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.openqa.selenium.testing.Ignore;
2222
import org.openqa.selenium.testing.JUnit4TestBase;
2323
import org.openqa.selenium.testing.JavascriptEnabled;
24+
import org.openqa.selenium.testing.NotYetImplemented;
2425

2526
import java.util.List;
2627

@@ -153,7 +154,7 @@ public void testFindElementByLinkText() {
153154
}
154155

155156
@Test
156-
@Ignore(value = {MARIONETTE}, reason = "Marionette: https://bugzilla.mozilla.org/show_bug.cgi?id=1204496")
157+
@NotYetImplemented(value = {MARIONETTE}, reason = "Marionette: https://bugzilla.mozilla.org/show_bug.cgi?id=1204496")
157158
public void testFindElementsByLinkTest() {
158159
driver.get(pages.nestedPage);
159160
WebElement element = driver.findElement(By.name("div1"));
@@ -204,7 +205,6 @@ public void testShouldFindChildrenByTagName() {
204205
assertEquals(2, elements.size());
205206
}
206207

207-
@JavascriptEnabled
208208
@Test
209209
public void testShouldBeAbleToFindAnElementByCssSelector() {
210210
driver.get(pages.nestedPage);
@@ -215,7 +215,6 @@ public void testShouldBeAbleToFindAnElementByCssSelector() {
215215
assertEquals("2", element.getAttribute("id"));
216216
}
217217

218-
@JavascriptEnabled
219218
@Test
220219
public void testShouldBeAbleToFindAnElementByCss3Selector() {
221220
driver.get(pages.nestedPage);
@@ -226,7 +225,6 @@ public void testShouldBeAbleToFindAnElementByCss3Selector() {
226225
assertEquals("2", element.getAttribute("id"));
227226
}
228227

229-
@JavascriptEnabled
230228
@Test
231229
public void testShouldBeAbleToFindElementsByCssSelector() {
232230
driver.get(pages.nestedPage);
@@ -291,7 +289,8 @@ public void testFindingByCssShouldNotIncludeParentElementIfSameTagType() {
291289
assertEquals("child", child.getAttribute("id"));
292290
}
293291

294-
@Ignore(value = {REMOTE, MARIONETTE}, reason = "Marionette: https://bugzilla.mozilla.org/show_bug.cgi?id=1204496")
292+
@Ignore({REMOTE})
293+
@NotYetImplemented(value = {MARIONETTE}, reason = "Marionette: https://bugzilla.mozilla.org/show_bug.cgi?id=1204496")
295294
@Test
296295
public void testFindMultipleElements() {
297296
driver.get(pages.simpleTestPage);
@@ -324,7 +323,7 @@ public void testLinkWithTrailingSpace() {
324323
}
325324

326325
@Test
327-
@Ignore(MARIONETTE)
326+
@NotYetImplemented(MARIONETTE)
328327
public void testElementCanGetLinkByLinkTestIgnoringTrailingWhitespace() {
329328
driver.get(pages.simpleTestPage);
330329
WebElement elem = driver.findElement(By.id("links"));

java/client/test/org/openqa/selenium/ClearTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
package org.openqa.selenium;
1919

2020
import org.junit.Test;
21-
import org.openqa.selenium.testing.Ignore;
2221
import org.openqa.selenium.testing.JUnit4TestBase;
2322

2423
import static org.junit.Assert.assertEquals;

0 commit comments

Comments
 (0)