[rb] get specs passing without stdout clutter

Author: titusfortner

rb/spec/unit/selenium/webdriver/common/logger_spec.rb

@@ -23,11 +23,11 @@ module Selenium
   module WebDriver
     describe Logger do
       around do |example|
-        WebDriver.instance_variable_set(:@logger, nil) # reset cache
         debug = $DEBUG
         $DEBUG = false
         example.call
         $DEBUG = debug
+        WebDriver.instance_variable_set(:@logger, nil) # reset cache
       end
 
       it 'logs warnings by default' do

rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb

@@ -25,7 +25,7 @@ module Remote
       module Http
         describe Default do
           let(:client) do
-            client            = Default.new
+            client = Default.new
             client.server_url = URI.parse('http://example.com')
 
             client
@@ -52,7 +52,9 @@ module Http
 
           describe '#timeout=' do
             let(:value_set) { 22 }
-            before { client.timeout = value_set }
+            before do
+              expect { client.timeout = value_set }.to output.to_stdout_from_any_process
+            end
 
             it 'assigns value to #read_timeout' do
               expect(client.read_timeout).to eq value_set
@@ -64,16 +66,16 @@ module Http
           end
 
           it 'uses the specified timeout' do
-            client.timeout = 10
-            http           = client.send :http
+            expect { client.timeout = 10 }.to output.to_stdout_from_any_process
+            http = client.send :http
 
             expect(http.open_timeout).to eq(10)
             expect(http.read_timeout).to eq(10)
           end
 
           it 'uses the specified proxy' do
             client.proxy = Proxy.new(http: 'http://foo:bar@proxy.org:8080')
-            http         = client.send :http
+            http = client.send :http
 
             expect(http).to be_proxy
             expect(http.proxy_address).to eq('proxy.org')
@@ -113,14 +115,14 @@ module Http
 
           %w[no_proxy NO_PROXY].each do |no_proxy_var|
             it "honors the #{no_proxy_var} environment variable when matching" do
-              with_env('HTTP_PROXY' => 'proxy.org:8080', no_proxy_var => 'example.com') do
+              with_env('http_proxy' => 'proxy.org:8080', no_proxy_var => 'example.com') do
                 http = client.send :http
                 expect(http).not_to be_proxy
               end
             end
 
             it "ignores the #{no_proxy_var} environment variable when not matching" do
-              with_env('HTTP_PROXY' => 'proxy.org:8080', no_proxy_var => 'foo.com') do
+              with_env('http_proxy' => 'proxy.org:8080', no_proxy_var => 'foo.com') do
                 http = client.send :http
 
                 expect(http).to be_proxy
@@ -130,23 +132,14 @@ module Http
             end
 
             it "understands a comma separated list of domains in #{no_proxy_var}" do
-              with_env('HTTP_PROXY' => 'proxy.org:8080', no_proxy_var => 'example.com,foo.com') do
+              with_env('http_proxy' => 'proxy.org:8080', no_proxy_var => 'example.com,foo.com') do
                 http = client.send :http
                 expect(http).not_to be_proxy
               end
             end
 
-            unless RUBY_VERSION > '2.0' # Ruby 2.0 does its own proxy handling in net/http, which breaks this behaviour
-              it "understands an asterisk in #{no_proxy_var}" do
-                with_env('HTTP_PROXY' => 'proxy.org:8080', no_proxy_var => '*') do
-                  http = client.send :http
-                  expect(http).not_to be_proxy
-                end
-              end
-            end
-
             it "understands subnetting in #{no_proxy_var}" do
-              with_env('HTTP_PROXY' => 'proxy.org:8080', no_proxy_var => 'localhost,127.0.0.0/8') do
+              with_env('http_proxy' => 'proxy.org:8080', no_proxy_var => 'localhost,127.0.0.0/8') do
                 client.server_url = URI.parse('http://127.0.0.1:4444/wd/hub')
 
                 http = client.send :http