Avoid looking up the driver provider more than once.

shs96c · shs96c · commit a9f88696ad6b · 2017-03-13T22:32:08.000Z
diff --git a/java/server/src/org/openqa/selenium/remote/server/DefaultDriverFactory.java b/java/server/src/org/openqa/selenium/remote/server/DefaultDriverFactory.java
@@ -57,7 +57,7 @@ DriverProvider getProviderMatching(Capabilities desired) {
   public WebDriver newInstance(Capabilities capabilities) {
     DriverProvider provider = getProviderMatching(capabilities);
     if (provider.canCreateDriverInstanceFor(capabilities)) {
-      return getProviderMatching(capabilities).newInstance(capabilities);
+      return provider.newInstance(capabilities);
     }
     throw new WebDriverException(String.format(
       "The best matching driver provider %s can't create a new driver instance for %s",

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ DriverProvider getProviderMatching(Capabilities desired) {`
`57`	`57`	`public WebDriver newInstance(Capabilities capabilities) {`
`58`	`58`	`DriverProvider provider = getProviderMatching(capabilities);`
`59`	`59`	`if (provider.canCreateDriverInstanceFor(capabilities)) {`
`60`		`- return getProviderMatching(capabilities).newInstance(capabilities);`
	`60`	`+ return provider.newInstance(capabilities);`
`61`	`61`	`}`
`62`	`62`	`throw new WebDriverException(String.format(`
`63`	`63`	`"The best matching driver provider %s can't create a new driver instance for %s",`