Skip to content

Commit ad9befd

Browse files
rbrishs96c
authored andcommitted
support ff17 also
Signed-off-by: Simon Stewart <simons@fb.com>
1 parent a8f771c commit ad9befd

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,18 @@ static BrowserVersion determineBrowserVersion(Capabilities capabilities) {
235235
}
236236

237237
if (BrowserType.FIREFOX.equals(browserName)) {
238-
return BrowserVersion.FIREFOX_24;
238+
// Try and convert the version
239+
try {
240+
int version = Integer.parseInt(browserVersion);
241+
switch (version) {
242+
case 17:
243+
return BrowserVersion.FIREFOX_17;
244+
default:
245+
return BrowserVersion.FIREFOX_24;
246+
}
247+
} catch (NumberFormatException e) {
248+
return BrowserVersion.FIREFOX_24;
249+
}
239250
}
240251

241252
if (BrowserType.CHROME.equals(browserName)) {

0 commit comments

Comments
 (0)